Review main Merged

78468[BUGFIX] Avoid unnecessary nesting in typo3-mfa-totp-url-info-button

Benjamin Kott CR +2 V +2 Normal +39 −25 updated 04/05/23, 14:30

Commit message

The web component should behave like a button, there is no need
to have another button nested inside. In addition we remove the
usage of native attributes for custom properties to avoid unintended
side effects.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benjamin Kott uploaded patch set 1 04/05/23, 07:20

  2. core-ci voted on patch set 1 V +1 04/05/23, 07:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40154

  3. Oliver Klee updated the commit message in patch set 2 V +1 04/05/23, 08:41

  4. core-ci voted on patch set 2 V +1 04/05/23, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40162

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 04/05/23, 14:20

  6. Oli Bartsch voted on patch set 2 V +2 CR +2 04/05/23, 14:30

  7. Oli Bartsch merged patch set 3 04/05/23, 14:30