78473[BUGFIX] Add frontend preview URL to CSP frame-src directive
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1318
-
Oliver Hader uploaded patch set 1 04/05/23, 09:03
-
core-ci voted on patch set 1 V +1 04/05/23, 09:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40165
-
Oliver Hader uploaded patch set 2
V +104/05/23, 09:33 -
core-ci voted on patch set 2 V +1 04/05/23, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40167
-
Oliver Hader uploaded patch set 3
V +104/05/23, 09:47 -
core-ci voted on patch set 3 V +1 04/05/23, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40169
-
Oliver Hader commented on patch set 3 04/05/23, 10:20
-
Tymoteusz Motylewski commented on patch set 3 04/05/23, 11:04
this didn't solve the issue with acc tests in CI, as the directive is invalid (doesn't contain domain i think): 09:57:46.194 SEVERE - http://web:8000/typo3temp/var/tests/acceptance/typo3/module/web/viewpage?token=135b8b7bf26bb4ff90624d3b00c685c80c1c9e48&id=227& - The source list for the Content Security Policy directive 'frame-src' contains an invalid source: '/typo3temp/var/tests/acceptance/styleguide-demo-227/'. It will be ignored. -
Oliver Hader uploaded patch set 4
V +104/05/23, 14:03 -
Oliver Hader commented on patch set 4 04/05/23, 14:05
The failure in other acc tests in still another topics, e.g. those tests are somehow using `http://localhost` as URI, even if the backend was accessed via `http://web:8000`...ViewModuleController.php:128ReplyDone -
core-ci voted on patch set 4 V +1 04/05/23, 14:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40188
-
Andreas Kienast voted on patch set 4 V +1 CR +1 04/05/23, 14:38
-
Andreas Kienast rebased onto patch set 5
CR +1V +104/06/23, 07:22 -
Andreas Kienast commented on patch set 5 V +1 CR +1 04/06/23, 07:26
Dang, my checkout wasn't clean -
core-ci voted on patch set 5 V +1 04/06/23, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40235
-
Benni Mack voted on patch set 5 V +1 CR +1 04/06/23, 07:39
-
Oliver Hader commented on patch set 5 V +2 CR +2 04/06/23, 07:51
Thx folks! -
Oliver Hader merged patch set 6 04/06/23, 07:51
ViewModuleController.php:128