Review main Merged

78476[TASK] Avoid DP with arguments

Christian Kuhn CR +2 V +2 Hard +432 −272 updated 04/05/23, 13:32

Commit message

phpunit 10 mumbles when test data provider
methods have arguments. This is used in
SiteHandling functional tests various times.

The patch refactors the data providers
to avoid this and declares them static
along the way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 14

Review log 810

  1. Christian Kuhn uploaded patch set 1 04/05/23, 12:02

  2. core-ci voted on patch set 1 V +1 04/05/23, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40182

  3. Benni Mack voted on patch set 1 V +1 CR +1 04/05/23, 12:16

  4. Oli Bartsch updated the commit message in patch set 2 CR +1 V +1 04/05/23, 12:18

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 04/05/23, 12:18

  6. Oliver Klee voted on patch set 2 CR +1 04/05/23, 12:22

  7. Benni Mack voted on patch set 2 V +1 CR +1 04/05/23, 13:22

  8. core-ci voted on patch set 2 V +1 04/05/23, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40183

  9. Christian Kuhn voted on patch set 2 V +2 CR +2 04/05/23, 13:32

  10. Christian Kuhn merged patch set 3 04/05/23, 13:32