Review main Merged

78478[BUGFIX] Apply no-cookie for vimeo when setting is missing

Ayke Halder CR +2 V +2 Easy +29 −16 updated 04/12/23, 11:35

Commit message

Improve the privacy of users by using the no-cookie setting
by default as fallback and set the do not track parameter to 1.

This fix recreates the behaviour already implemented for YouTube
embedded media to also apply for Vimeo embedded media:
If the setting 'no-cookie' is not set at all then use the
'no-cookie' url anyway.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Ayke Halder uploaded patch set 1 04/05/23, 14:05

  2. core-ci voted on patch set 1 V -1 04/05/23, 14:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40189

  3. Ayke Halder uploaded patch set 2 V -1 04/05/23, 14:57

  4. core-ci voted on patch set 2 V +1 04/05/23, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40197

  5. Anja Leichsenring updated the commit message in patch set 3 V +1 04/11/23, 17:17

  6. Anja Leichsenring commented on patch set 3 V +1 CR +1 04/11/23, 17:17

    10.4 is in ELTS now, I removed the version from the releases line.
  7. core-ci voted on patch set 3 V +1 04/11/23, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40474

  8. Oliver Klee voted on patch set 3 CR +1 04/11/23, 17:49

  9. Georg Ringer voted on patch set 3 V +2 CR +2 04/12/23, 04:45

  10. Georg Ringer merged patch set 4 04/12/23, 04:45

  11. Ayke Halder commented on patch set 3 04/12/23, 11:04

    Reply

    10.4 will be in ELTS by April 30th.
  12. Benni Mack commented on patch set 4 04/12/23, 11:35

    Reply

    ayke halder is correct here.