Review main Merged

78480[TASK] Remove BackendModuleControllerTest

Christian Kuhn CR +2 V +2 Normal +0 −117 updated 04/05/23, 15:23

Commit message

This test is tricky since the subject triggers
session_save_path() which is limited to one
call per php process and emits a warning when
called multiple times.

This was mitigated by adding an own exception
handler in the test setup, but this solution
fails with phpunit 10, which is more picky
and can't be tricked easily.

The value added by the test is not *that*
high and the overall setup is complex, so
in this case, it's better to remove the test.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 04/05/23, 14:39

  2. Christian Kuhn updated the commit message in patch set 2 04/05/23, 14:41

  3. Andreas Kienast voted on patch set 2 V +1 CR +1 04/05/23, 14:42

  4. Oliver Klee voted on patch set 2 V +1 CR +1 04/05/23, 14:44

  5. core-ci voted on patch set 1 V +1 04/05/23, 14:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40194

  6. core-ci voted on patch set 2 V +1 04/05/23, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40195

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 04/05/23, 15:23

  8. Christian Kuhn merged patch set 3 04/05/23, 15:23