Review main Merged

78483[TASK] Extract callbacks from TypoScriptFrontendControllerTest

Christian Kuhn CR +2 V +2 Normal +63 −42 updated 04/05/23, 17:05

Commit message

TypoScriptFrontendControllerTest uses itself as
callback for USER and USER_INT functions. This
does not work anymore since phpunit 10 TestCase
has a basic constructor which fails when TYPO3
creates an object of this class.

Extract those callbacks to an own class.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 56

  1. Christian Kuhn uploaded patch set 1 04/05/23, 15:22

  2. core-ci voted on patch set 1 V +1 04/05/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40199

  3. Oliver Klee voted on patch set 1 V +1 04/05/23, 15:43

  4. Oliver Klee voted on patch set 1 CR +1 04/05/23, 15:43

  5. Christian Kuhn commented on patch set 1 V +2 CR +2 04/05/23, 17:05

    i hope it's ok to merge this exceptionally, even without a coredev vote.
  6. Christian Kuhn merged patch set 2 04/05/23, 17:05