78485[BUGFIX] Correct treelist-renderings
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Markus Klein +1
-
Verified V +2 Done
- Andreas Kienast +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 25
- Build/Sources/Sass/component/_diff.scss3+16 −16
- Build/Sources/Sass/component/_panel.scss+5 −0
- Build/Sources/Sass/component/_treelist.scssnew+255 −0
- Build/Sources/Sass/module/_backenduser.scssdeleted+0 −9
- Build/Sources/Sass/module/_tstemplate.scssdeleted+0 −28
- Build/Sources/Sass/typo3/_element_tree.scss+2 −216
- Build/Sources/Sass/backend.scss+1 −2
- Build/Sources/TypeScript/backend/utility/collapse-state-search.ts+4 −4
- typo3/sysext/adminpanel/Resources/Public/Css/adminpanel.css+1 −1
- typo3/sysext/backend/Classes/Tree/View/AbstractTreeView.php+3 −3
- typo3/sysext/backend/Classes/Tree/View/ElementBrowserPageTreeView.php+15 −14
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+4 −4
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html+42 −37
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Includes.html+16 −16
- typo3/sysext/backend/Resources/Public/Css/backend.css+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/utility/collapse-state-search.js+1 −1
- typo3/sysext/beuser/Resources/Private/Partials/Compare/Information.html+5 −4
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+3 −3
- typo3/sysext/impexp/Classes/View/ExportPageTreeView.php+7 −13
- typo3/sysext/impexp/Tests/Functional/Export/ExportPageTreeViewTest.php+2 −2
Show 5 more files
- typo3/sysext/lowlevel/Classes/Controller/ConfigurationController.php+17 −12
- typo3/sysext/tstemplate/Resources/Private/Partials/ActiveTree.html+41 −36
- typo3/sysext/tstemplate/Resources/Private/Partials/ActiveTreePanel.html+1 −1
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerTree.html+26 −24
- typo3/sysext/tstemplate/Resources/Private/Partials/AnalyzerTreePanel.html+2 −2
Review log 2130
Show 45 earlier messages
-
Benjamin Kott uploaded patch set 1 04/05/23, 16:05
-
Benni Mack commented on patch set 1 04/05/23, 16:16
see https://review.typo3.org/c/Packages/TYPO3.CMS/+/78315 (we're going to deprecate ElementBrowserPageTreeView). However I think we should keep your solution as is. -
core-ci voted on patch set 1 V -1 04/05/23, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40201
-
Benjamin Kott uploaded patch set 2
V -104/06/23, 08:24 -
Oliver Klee updated the commit message in patch set 3 04/06/23, 08:27
-
core-ci voted on patch set 2 V +1 04/06/23, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40238
-
core-ci voted on patch set 3 V +1 04/06/23, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40240
-
Benjamin Kott uploaded patch set 4
V +104/06/23, 08:45 -
Benjamin Kott uploaded patch set 5 04/06/23, 08:46
-
core-ci voted on patch set 5 V +1 04/06/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40246
-
core-ci voted on patch set 4 V -1 04/06/23, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40245
-
Christian Kuhn commented on patch set 5 04/06/23, 10:15
special thanks for a great commit message! the change needs to be well tested in the pagetsconfig and typoscript module - there are some tricky things with search highlighting, constant substitutions and similar. it would be great if these don't break. -
Benjamin Kott commented on patch set 5 CR -1 04/06/23, 11:19
Reply
while everyting is still working, that was missed during the rebuild iterations - on it. -
Benjamin Kott commented on patch set 5 04/06/23, 11:20
Reply
i meant there is an overflow, that not supposed to be there- somehow lost. -
Benjamin Kott uploaded patch set 6
CR -1V +104/06/23, 11:52 -
core-ci voted on patch set 6 V +1 04/06/23, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40282
-
Andreas Kienast rebased onto patch set 7
V +104/06/23, 12:19 -
core-ci voted on patch set 7 V +1 04/06/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40284
-
Andreas Kienast uploaded patch set 8
V +104/06/23, 12:45 -
Andreas Kienast voted on patch set 8 V +1 CR +1 04/06/23, 12:47
-
core-ci voted on patch set 8 V +1 04/06/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40288
-
Benjamin Kott uploaded patch set 9
CR +1V +104/07/23, 07:59 -
Benjamin Kott commented on patch set 9 04/07/23, 08:00
rebase -
core-ci voted on patch set 9 V +1 04/07/23, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40325
-
Markus Klein commented on patch set 9 04/07/23, 09:11
Are the .list-tree classes removed completely? If so, isn't this a breaking change?_diff.scss:40why introducing more nesting here? -
Benjamin Kott commented on patch set 9 04/07/23, 09:23
Reply
This part of the CSS is not considered, or documented as public API and used internally only._diff.scss:40Replyas mentioned in the commmit message: The diff component was used in an unintended space and was not used as documented. That made manual adaptions necessary that now have been revoked. Instead, we now only apply the table structure only if the nesting is correct. So the parts of the component can be used in other places for now. While we are here, we are adapting and streamlining the colors of the diff component. -
Markus Klein commented on patch set 9 04/07/23, 09:40
Reply
Ack -
Markus Klein commented on patch set 9 V +1 CR +1 04/07/23, 13:12
_diff.scss:40ReplyGot it. We adjust the CSS and not the wrong usages. -
Andreas Kienast voted on patch set 9 V +2 CR +2 04/07/23, 13:40
-
Andreas Kienast merged patch set 10 04/07/23, 13:40