Review main Merged

78485[BUGFIX] Correct treelist-renderings

Benjamin Kott CR +2 V +2 Hard +471 −450 updated 04/07/23, 13:40

Commit message

This is the first step to correct the CSS list-tree. Even it is
documented in the style guide extension it was managed to have
several kinds of implementation through the core.

To make it clear and force people to look up the actual use, we are
now also streamlining the naming scheme.

Old: .list-tree
New: .treelist

This led to a misplacement of the open/collapsed indicator/toggle
of tree branches. The control element was somehow moved inside the
treelist-group, which is purely intended to handle a single row of
informational content. In addition collapse classes were mixed up
with tree stylings, which lead to cut-off indicators, and sluggish
opening and close animations.

Helpers to make tables responsive where used out of place to achieve
similar but different behavior for panels that are intended to
overflow if the content is too long.

The diff component was used in an unintended space and was not
used as documented. That made manual adaptions necessary that now
have been revoked. Instead, we now only apply the table structure
only if the nesting is correct. So the parts of the component can
be used in other places for now. While we are here, we are adapting
and streamlining the colors of the diff component.

All randomly placed text-monospace classes were removed from the
table rendering and are now only applied to the information group
if necessary. This avoids having badges, buttons, etc restyled
to a monospace font.

The styling adaptions in the import/export module were incomplete
and several necessary corrections were missing. We now made it
easier to define the background color for the element.

Misplaced control CSS classes that seem to be leftovers have been
removed from elements they don`t belong to.

As mentioned, this patch is part of the ongoing cleanup and has no
intention to be finished or solve all the remaining issues.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 25

Show 5 more files

Review log 2130

Show 45 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/05/23, 16:05

  2. Benni Mack commented on patch set 1 04/05/23, 16:16

    see https://review.typo3.org/c/Packages/TYPO3.CMS/+/78315 (we're going to deprecate ElementBrowserPageTreeView). However I think we should keep your solution as is.
  3. core-ci voted on patch set 1 V -1 04/05/23, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40201

  4. Benjamin Kott uploaded patch set 2 V -1 04/06/23, 08:24

  5. Oliver Klee updated the commit message in patch set 3 04/06/23, 08:27

  1. core-ci voted on patch set 2 V +1 04/06/23, 08:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40238

  2. core-ci voted on patch set 3 V +1 04/06/23, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40240

  3. Benjamin Kott uploaded patch set 4 V +1 04/06/23, 08:45

  4. Benjamin Kott uploaded patch set 5 04/06/23, 08:46

  5. core-ci voted on patch set 5 V +1 04/06/23, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40246

  6. core-ci voted on patch set 4 V -1 04/06/23, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40245

  7. Christian Kuhn commented on patch set 5 04/06/23, 10:15

    special thanks for a great commit message! the change needs to be well tested in the pagetsconfig and typoscript module - there are some tricky things with search highlighting, constant substitutions and similar. it would be great if these don't break.
  8. Benjamin Kott commented on patch set 5 CR -1 04/06/23, 11:19

    Reply

    while everyting is still working, that was missed during the rebuild iterations - on it.
  9. Benjamin Kott commented on patch set 5 04/06/23, 11:20

    Reply

    i meant there is an overflow, that not supposed to be there- somehow lost.
  10. Benjamin Kott uploaded patch set 6 CR -1 V +1 04/06/23, 11:52

  11. core-ci voted on patch set 6 V +1 04/06/23, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40282

  12. Andreas Kienast rebased onto patch set 7 V +1 04/06/23, 12:19

  13. core-ci voted on patch set 7 V +1 04/06/23, 12:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40284

  14. Andreas Kienast uploaded patch set 8 V +1 04/06/23, 12:45

  15. Andreas Kienast voted on patch set 8 V +1 CR +1 04/06/23, 12:47

  16. core-ci voted on patch set 8 V +1 04/06/23, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40288

  17. Benjamin Kott uploaded patch set 9 CR +1 V +1 04/07/23, 07:59

  18. Benjamin Kott commented on patch set 9 04/07/23, 08:00

    rebase
  19. core-ci voted on patch set 9 V +1 04/07/23, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40325

  20. Markus Klein commented on patch set 9 04/07/23, 09:11

    Are the .list-tree classes removed completely? If so, isn't this a breaking change?

    _diff.scss:40

    why introducing more nesting here?
  21. Benjamin Kott commented on patch set 9 04/07/23, 09:23

    Reply

    This part of the CSS is not considered, or documented as public API and used internally only.

    _diff.scss:40 Reply

    as mentioned in the commmit message: The diff component was used in an unintended space and was not used as documented. That made manual adaptions necessary that now have been revoked. Instead, we now only apply the table structure only if the nesting is correct. So the parts of the component can be used in other places for now. While we are here, we are adapting and streamlining the colors of the diff component.
  22. Markus Klein commented on patch set 9 04/07/23, 09:40

    Reply

    Ack
  23. Markus Klein commented on patch set 9 V +1 CR +1 04/07/23, 13:12

    _diff.scss:40 Reply

    Got it. We adjust the CSS and not the wrong usages.
  24. Andreas Kienast voted on patch set 9 V +2 CR +2 04/07/23, 13:40

  25. Andreas Kienast merged patch set 10 04/07/23, 13:40