Review main Merged

78486[TASK] Avoid withConsecutive() in FlexFormToolsTest

Christian Kuhn CR +2 V +2 Normal +102 −16 updated 04/05/23, 17:04

Commit message

The tests should be refactored towards proper
database fixtures, but for now, we get rid of
withConsecutive().

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 04/05/23, 16:31

  2. Christian Kuhn uploaded patch set 2 04/05/23, 16:31

  3. Oliver Klee voted on patch set 2 CR +1 04/05/23, 16:40

  4. core-ci voted on patch set 1 V +1 04/05/23, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40202

  5. core-ci voted on patch set 2 V +1 04/05/23, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40203

  6. Oliver Klee voted on patch set 2 V +1 04/05/23, 16:43

  7. Christian Kuhn commented on patch set 2 V +2 CR +2 04/05/23, 17:04

    will merge this even with incomplete votes: it's similar to what is done with other tests.
  8. Christian Kuhn merged patch set 3 04/05/23, 17:04