Review main Merged

78488[TASK] Improve WebhookExecutionTest

Christian Kuhn CR +2 V +2 Normal +90 −25 updated 04/05/23, 19:28

Commit message

This test case of ext:webhooks is a bit weird.

The patch relaxes this a bit: Extending a
ext:core abstract is avoided, the setup is
streamlined, and abusing ext:core fixture
files is avoided.

With phpunit 10, one of the three tests fails,
probably because its broken, but the details
are unclear. It's marked as skipped for now.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 69

  1. Christian Kuhn uploaded patch set 1 04/05/23, 17:57

  2. core-ci voted on patch set 1 V -1 04/05/23, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40206

  3. Christian Kuhn uploaded patch set 2 V -1 04/05/23, 18:25

  4. core-ci voted on patch set 2 V -1 04/05/23, 18:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40213

  5. Christian Kuhn uploaded patch set 3 V -1 04/05/23, 18:51

  6. core-ci voted on patch set 3 V +1 04/05/23, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40215

  7. Oliver Klee voted on patch set 3 V +1 04/05/23, 19:04

  8. Christian Kuhn commented on patch set 3 V +2 CR +2 04/05/23, 19:28

    i'll bend rules a bit and will merge this to have functionals with phpunit 10 active in next nightly.
  9. Christian Kuhn merged patch set 4 04/05/23, 19:28