78488[TASK] Improve WebhookExecutionTest
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 5
- Build/phpstan/phpstan-baseline.neon+5 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/AbstractDataHandlerActionTestCase.php+3 −1
- typo3/sysext/webhooks/Tests/Functional/Fixtures/be_users_admin.csvnew+4 −0
- typo3/sysext/webhooks/Tests/Functional/Fixtures/pages.csvnew+30 −0
- typo3/sysext/webhooks/Tests/Functional/WebhookExecutionTest.php+48 −24
Review log 69
-
Christian Kuhn uploaded patch set 1 04/05/23, 17:57
-
core-ci voted on patch set 1 V -1 04/05/23, 18:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40206
-
Christian Kuhn uploaded patch set 2
V -104/05/23, 18:25 -
core-ci voted on patch set 2 V -1 04/05/23, 18:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40213
-
Christian Kuhn uploaded patch set 3
V -104/05/23, 18:51 -
core-ci voted on patch set 3 V +1 04/05/23, 18:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40215
-
Oliver Klee voted on patch set 3 V +1 04/05/23, 19:04
-
Christian Kuhn commented on patch set 3 V +2 CR +2 04/05/23, 19:28
i'll bend rules a bit and will merge this to have functionals with phpunit 10 active in next nightly. -
Christian Kuhn merged patch set 4 04/05/23, 19:28