Review main Merged

78490[TASK] Rename AbstractXmlSitemapPagesTest

Christian Kuhn CR +2 V +2 Easy +3 −3 updated 04/05/23, 18:47

Commit message

phpunit 10 expects classes that end with "Test"
to not be abstract.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 57

  1. Christian Kuhn uploaded patch set 1 04/05/23, 18:08

  2. Christian Kuhn voted on patch set 1 CR -1 04/05/23, 18:10

  3. Christian Kuhn uploaded patch set 2 CR -1 04/05/23, 18:14

  4. core-ci voted on patch set 1 V +1 04/05/23, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40208

  5. core-ci voted on patch set 2 V +1 04/05/23, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40210

  6. Christian Kuhn commented on patch set 2 V +2 CR +2 04/05/23, 18:47

    i'll bend rules a bit and will merge this to have functionals with phpunit 10 active in next nightly.
  7. Christian Kuhn merged patch set 3 04/05/23, 18:47