78501[BUGFIX] Move module state into reloadable part of DOM
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/TypeScript/backend/module-menu.ts+4 −3
- Build/Sources/TypeScript/backend/module.ts+18 −4
- typo3/sysext/backend/Classes/Controller/BackendController.php+4 −1
- typo3/sysext/backend/Resources/Private/Partials/Backend/ModuleMenu.html+1 −0
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+2 −2
- typo3/sysext/backend/Resources/Private/Templates/Backend/ModuleMenu.html+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module.js+1 −1
Review log 1216
-
Andreas Kienast uploaded patch set 1 04/06/23, 07:22
-
core-ci voted on patch set 1 V +1 04/06/23, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40236
-
Benni Mack commented on patch set 1 04/06/23, 07:42
Ideally we'd use state handling ;) in the future -
Andreas Kienast uploaded patch set 2
V +104/06/23, 08:31 -
core-ci voted on patch set 2 V +1 04/06/23, 08:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40241
-
Benjamin Kott commented on patch set 2 04/06/23, 09:00
As mentioned in the comments in https://review.typo3.org/c/Packages/TYPO3.CMS/+/75879 this does only solve the problem partly again. We are currently stuck, since when new extensions are installed we also need to consider that they can add css/js to the global scope. This can only be solved by reloading the backend entirely in it´s current state. -
Andreas Kienast rebased onto patch set 3
V +108/03/23, 18:53 -
core-ci voted on patch set 3 V +1 08/03/23, 19:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44943
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 08/04/23, 11:09
-
Christian Kuhn updated the commit message in patch set 4
CR +1V +108/05/23, 20:27 -
Christian Kuhn voted on patch set 4 V +1 CR +1 08/05/23, 20:27
-
core-ci voted on patch set 4 V +1 08/05/23, 20:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45125
-
Stefan Bürk voted on patch set 4 V +1 CR +1 08/06/23, 16:38
-
Benni Mack voted on patch set 4 V +1 CR +1 08/07/23, 08:54
-
Andreas Kienast voted on patch set 4 V +2 CR +2 08/07/23, 12:04
-
Andreas Kienast merged patch set 5 08/07/23, 12:04