Review main Merged

78504[TASK] Run deprecated unit tests with phpunit 10

Christian Kuhn CR +2 V +2 Normal +126 −23 updated 04/06/23, 09:51

Commit message

Unit deprecated tests are quite easy to fix
for phpunit 10: Just static data providers
and a single broken test case usage.

We do the same as with "casual" unit tests:
Temporarily allowing execution with phpunit 10
in runTests.sh in addition to phpunit 9, plus
CI addition.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 12

Review log 811

  1. Christian Kuhn uploaded patch set 1 04/06/23, 08:31

  2. Christian Kuhn updated the commit message in patch set 2 04/06/23, 08:34

  3. Christian Kuhn uploaded patch set 3 04/06/23, 08:47

  4. core-ci voted on patch set 3 V -1 04/06/23, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40247

  5. core-ci voted on patch set 2 V -1 04/06/23, 09:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40244

  6. Christian Kuhn uploaded patch set 4 V -1 04/06/23, 09:01

  7. Stefan Bürk voted on patch set 4 V +1 CR +1 04/06/23, 09:21

  8. core-ci voted on patch set 4 V +1 04/06/23, 09:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40248

  9. Christian Kuhn voted on patch set 4 V +2 CR +2 04/06/23, 09:50

  10. Christian Kuhn merged patch set 5 04/06/23, 09:50

  11. Oliver Klee voted on patch set 4 V +1 04/06/23, 09:51