Review main Merged

78509[BUGFIX] Fix CSP violation in extension manager

Andreas Kienast CR +2 V +2 Easy +25 −0 updated 04/06/23, 11:07

Commit message

The Extension Manager module for distributions attempts to load
resources from a 3rd party resource (extensions.typo3.org), leading
to a CSP violation.

A new `ContentSecurityPolicies` configuration is added to
EXT:extensionmanager that allows extensions.typo3.org.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1822

  1. Andreas Kienast uploaded patch set 1 04/06/23, 09:25

  2. Andreas Kienast uploaded patch set 2 04/06/23, 09:26

  3. Andreas Kienast uploaded patch set 3 04/06/23, 09:26

  4. Andreas Kienast uploaded patch set 4 04/06/23, 09:27

  5. core-ci voted on patch set 4 V +1 04/06/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40258

  6. Oliver Hader commented on patch set 4 04/06/23, 09:57

    On it..
  7. Oliver Hader uploaded patch set 5 V +1 04/06/23, 09:58

  8. Oliver Hader commented on patch set 5 04/06/23, 10:00

    Using LitElement seems to be an unrelated drive-by fix. It looks fine, but could you please extract it to a separate patch, since it does not seem to be related to CSP.
  9. Oliver Hader commented on patch set 5 04/06/23, 10:01

    ContentSecurityPolicies.php:22

    I made it a litte bit more explicit by adding the `https://` scheme as well.
  10. core-ci voted on patch set 5 V +1 04/06/23, 10:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40263

  11. Andreas Kienast commented on patch set 5 04/06/23, 10:14

    Reply

    Well, originally there were two CSP issues. One of that is gone with the migration to Lit but I can do that.
  12. Andreas Kienast commented on patch set 5 04/06/23, 10:20

  13. Oliver Hader commented on patch set 5 04/06/23, 10:26

    Reply

    Ah, I see `Refused to apply inline style ...` - which only appears if `style-src: nonce-...` is required. When switching to shadow DOM, this is picked up automatically in LitElement from `window.litNonce`... 👍
  14. Oliver Hader uploaded patch set 6 V +1 04/06/23, 10:30

  15. Oliver Hader voted on patch set 6 V +1 CR +1 04/06/23, 10:30

  16. Oliver Hader uploaded patch set 7 04/06/23, 10:34

    Copied Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR is:MIN") * Verified+1 (copy condition: "changekind:NO_CHANGE")
  17. Oliver Hader voted on patch set 7 V +1 CR +1 04/06/23, 10:35

  18. core-ci voted on patch set 6 V +1 04/06/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40269

  19. core-ci voted on patch set 7 V +1 04/06/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40270

  20. Stefan Bürk voted on patch set 7 V +1 CR +1 04/06/23, 11:06

  21. Andreas Kienast voted on patch set 7 V +2 CR +2 04/06/23, 11:07

  22. Andreas Kienast merged patch set 8 04/06/23, 11:07