Review main Merged

78511[TASK] Slightly improve database relation check rendering

Benjamin Kott CR +2 V +2 Easy +6 −5 updated 04/06/23, 11:06

Commit message

We are now rendering the result as a list instead of a single
text blob divided by line breaks and adding a highlight to
the missing record.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Benjamin Kott uploaded patch set 1 04/06/23, 09:30

  2. Oliver Klee voted on patch set 1 CR +1 04/06/23, 09:53

  3. core-ci voted on patch set 1 V +1 04/06/23, 09:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40260

  4. Oli Bartsch commented on patch set 1 04/06/23, 10:27

    DatabaseIntegrityCheck.php:540

    Let's simplify this a bit.
  5. Oli Bartsch uploaded patch set 2 CR +1 V +1 04/06/23, 10:28

  6. Oli Bartsch commented on patch set 2 V +1 CR +1 04/06/23, 10:30

    DatabaseIntegrityCheck.php:540 Reply

    Done
  7. Andreas Kienast commented on patch set 2 V +1 CR +2 04/06/23, 10:34

    waiting for CI
  8. Oliver Klee voted on patch set 2 CR +1 04/06/23, 10:34

  9. core-ci voted on patch set 2 V -1 04/06/23, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40268

  10. Andreas Kienast commented on patch set 2 04/06/23, 11:01

    Looks like a random timeout, restarted...
  11. core-ci voted on patch set 2 V +1 04/06/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40268

  12. Andreas Kienast voted on patch set 2 V +2 04/06/23, 11:06

  13. Andreas Kienast merged patch set 3 04/06/23, 11:06