Review main Merged

78512[BUGFIX] Grant inline scripts & styles via CSP in admin panel output

Oliver Hader CR +2 V +2 Normal +126 −16 updated 06/26/23, 11:29

Commit message

The admin panel uses Symfony's `HtmlDumper` to output data - which is
adding inline JavaScript and StyleSheet elements. To be compatible with
CSP those elements need to be allowed with a nonce attribute.

This change relies on a merged pull request for Symfony v6.3:
https://github.com/symfony/symfony/pull/49977

Executed commands:
composer req symfony/var-dumper:^6.3
composer req symfony/var-dumper:^6.3 \
  -d typo3/sysext/adminpanel --no-update

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2032

Show 47 earlier messages
  1. Oliver Hader uploaded patch set 1 04/06/23, 09:38

  2. core-ci voted on patch set 1 V -1 04/06/23, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40261

  3. Oliver Hader uploaded patch set 2 V -1 04/07/23, 10:57

  4. core-ci voted on patch set 2 V +1 04/07/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40329

  5. Oliver Hader uploaded patch set 3 V +1 04/08/23, 09:11

  6. core-ci voted on patch set 3 V -1 04/08/23, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40367

  7. Oliver Hader uploaded patch set 4 V -1 05/14/23, 14:20

  1. Oliver Hader commented on patch set 4 05/14/23, 14:21

    This change is ready for review.
  2. core-ci voted on patch set 4 V +1 05/14/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41821

  3. Oliver Hader uploaded patch set 5 V +1 05/19/23, 06:14

  4. core-ci voted on patch set 5 V -1 05/19/23, 06:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41923

  5. Torben Hansen updated the commit message in patch set 6 V -1 05/20/23, 09:55

  6. core-ci voted on patch set 6 V -1 05/20/23, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41935

  7. Oliver Hader uploaded patch set 7 V -1 05/23/23, 07:53

  8. core-ci voted on patch set 7 V -1 05/23/23, 08:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41968

  9. Oliver Hader uploaded patch set 8 V -1 05/30/23, 20:56

  10. core-ci voted on patch set 8 V -1 05/30/23, 21:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42097

  11. Oliver Hader uploaded patch set 9 V -1 05/30/23, 21:08

  12. core-ci voted on patch set 9 V +1 05/30/23, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42098

  13. Benni Mack voted on patch set 9 V +1 CR +1 05/31/23, 15:18

  14. Oliver Hader uploaded patch set 10 CR +1 V +1 06/01/23, 09:18

  15. core-ci voted on patch set 10 V +1 06/01/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42139

  16. Oliver Hader uploaded patch set 11 V +1 06/07/23, 10:10

  17. Mathias Brodala commented on patch set 11 06/07/23, 10:18

    HtmlDumper.php:28

    Would it be possible to use decoration instead? This way we are safe in case Symfony decides to mark this class as final.
  18. core-ci voted on patch set 11 V +1 06/07/23, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42263

  19. Oliver Hader commented on patch set 11 06/07/23, 10:39

    HtmlDumper.php:28 Reply

    Would be difficult currently since the most specific function `getDumpHeader` is `protected`. In case Symfony decides to make the class final, we can (have to) adjust it at that time...
  20. Mathias Brodala commented on patch set 11 06/07/23, 12:39

    HtmlDumper.php:28 Reply

    OK, thanks for having a look nevertheless.
  21. Oliver Hader uploaded patch set 12 V +1 06/26/23, 08:44

  22. core-ci voted on patch set 12 V +1 06/26/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42980

  23. Benni Mack voted on patch set 12 V +1 CR +1 06/26/23, 10:36

  24. Georg Ringer voted on patch set 12 V +2 CR +2 06/26/23, 11:29

  25. Georg Ringer merged patch set 13 06/26/23, 11:29