78512[BUGFIX] Grant inline scripts & styles via CSP in admin panel output
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/adminpanel/Classes/Modules/Debug/Events.php+7 −1
- typo3/sysext/adminpanel/Classes/Utility/HtmlDumper.php3new+60 −0
- typo3/sysext/adminpanel/Configuration/ContentSecurityPolicies.phpnew+28 −0
- typo3/sysext/adminpanel/Configuration/Services.yaml+2 −0
- typo3/sysext/adminpanel/composer.json+1 −1
- typo3/sysext/frontend/Classes/Html/HtmlWorker.php+20 −0
- composer.json+1 −1
- composer.lock+7 −13
Review log 2032
Show 47 earlier messages
-
Oliver Hader uploaded patch set 1 04/06/23, 09:38
-
core-ci voted on patch set 1 V -1 04/06/23, 10:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40261
-
Oliver Hader uploaded patch set 2
V -104/07/23, 10:57 -
core-ci voted on patch set 2 V +1 04/07/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40329
-
Oliver Hader uploaded patch set 3
V +104/08/23, 09:11 -
core-ci voted on patch set 3 V -1 04/08/23, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40367
-
Oliver Hader uploaded patch set 4
V -105/14/23, 14:20
-
Oliver Hader commented on patch set 4 05/14/23, 14:21
This change is ready for review. -
core-ci voted on patch set 4 V +1 05/14/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41821
-
Oliver Hader uploaded patch set 5
V +105/19/23, 06:14 -
core-ci voted on patch set 5 V -1 05/19/23, 06:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41923
-
Torben Hansen updated the commit message in patch set 6
V -105/20/23, 09:55 -
core-ci voted on patch set 6 V -1 05/20/23, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41935
-
Oliver Hader uploaded patch set 7
V -105/23/23, 07:53 -
core-ci voted on patch set 7 V -1 05/23/23, 08:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41968
-
Oliver Hader uploaded patch set 8
V -105/30/23, 20:56 -
core-ci voted on patch set 8 V -1 05/30/23, 21:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42097
-
Oliver Hader uploaded patch set 9
V -105/30/23, 21:08 -
core-ci voted on patch set 9 V +1 05/30/23, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42098
-
Benni Mack voted on patch set 9 V +1 CR +1 05/31/23, 15:18
-
Oliver Hader uploaded patch set 10
CR +1V +106/01/23, 09:18 -
core-ci voted on patch set 10 V +1 06/01/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42139
-
Oliver Hader uploaded patch set 11
V +106/07/23, 10:10 -
Mathias Brodala commented on patch set 11 06/07/23, 10:18
HtmlDumper.php:28Would it be possible to use decoration instead? This way we are safe in case Symfony decides to mark this class as final. -
core-ci voted on patch set 11 V +1 06/07/23, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42263
-
Oliver Hader commented on patch set 11 06/07/23, 10:39
HtmlDumper.php:28ReplyWould be difficult currently since the most specific function `getDumpHeader` is `protected`. In case Symfony decides to make the class final, we can (have to) adjust it at that time... -
Mathias Brodala commented on patch set 11 06/07/23, 12:39
HtmlDumper.php:28ReplyOK, thanks for having a look nevertheless. -
Oliver Hader uploaded patch set 12
V +106/26/23, 08:44 -
core-ci voted on patch set 12 V +1 06/26/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42980
-
Benni Mack voted on patch set 12 V +1 CR +1 06/26/23, 10:36
-
Georg Ringer voted on patch set 12 V +2 CR +2 06/26/23, 11:29
-
Georg Ringer merged patch set 13 06/26/23, 11:29