78514[TASK] Clean up fixCopyAfterDuplFields
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 810
-
Oli Bartsch uploaded patch set 1 04/06/23, 10:06
-
core-ci voted on patch set 1 V +1 04/06/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40265
-
Christian Kuhn commented on patch set 1 04/06/23, 10:56
DataHandler.php:8785you're sure it's fine we now rely on the parent method to perform the field updates? no chance for some side-effect or chicken-egg issue? -
Oli Bartsch uploaded patch set 2
V +104/06/23, 11:35 -
Oli Bartsch commented on patch set 2 04/06/23, 11:36
DataHandler.php:8774ReplyDoneDataHandler.php:8785ReplyThe method is called only once and previously had $update set to FALSE. Therefore this was never executed. -
Benni Mack commented on patch set 2 04/06/23, 11:39
DataHandler.php:8784updateDB() is gone? -
core-ci voted on patch set 2 V +1 04/06/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40279
-
Benni Mack commented on patch set 2 V +1 CR +1 04/06/23, 13:37
Fine. Thanks!DataHandler.php:8784ReplyDone -
Christian Kuhn commented on patch set 2 V +2 CR +2 04/06/23, 18:47
DataHandler.php:8785ReplyAh, missed that. Thx! -
Christian Kuhn merged patch set 3 04/06/23, 18:47
DataHandler.php:8774