Review main Merged

78529[BUGFIX] Fix undefined array key warnings in DatabaseIntegrityController

Torben Hansen CR +2 V +2 Easy +19 −17 updated 04/07/23, 11:48

Commit message

Since #99739 the TCA types select, radio and check use associative
array keys for their items.

In ext:lowlevel DatabaseIntegrityController, some functions still access
indexed array keys, which leads to a PHP warning.

This change ensures that the associative array keys introduced in #99739
are used.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Torben Hansen uploaded patch set 1 04/06/23, 17:02

  2. Oliver Klee updated the commit message in patch set 2 04/06/23, 17:03

  3. Nikita Hovratov voted on patch set 2 V +1 CR +1 04/06/23, 17:09

  4. core-ci voted on patch set 1 V +1 04/06/23, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40310

  5. core-ci voted on patch set 2 V +1 04/06/23, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40311

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 04/06/23, 18:08

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 04/07/23, 11:48

  8. Stefan Bürk merged patch set 3 04/07/23, 11:48