Review main Merged

78532[TASK] Add close confirmation modal to scheduler

Jochen Roth CR +2 V +2 Normal +67 −4 updated 04/13/23, 12:14

Commit message

Currently, if a task was changed in the edit/add view
the close button goes back to list view without
letting the user know about potentially lost changes.

This has been changed, by adding a confirmation modal
when the close button was clicked but changes are not
yet saved.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Jochen Roth uploaded patch set 1 04/06/23, 21:06

  2. core-ci voted on patch set 1 V -1 04/06/23, 22:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40319

  3. Jochen Roth uploaded patch set 2 V -1 04/08/23, 08:31

  4. core-ci voted on patch set 2 V +1 04/08/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40364

  5. Benni Mack voted on patch set 2 CR +1 04/12/23, 11:26

  6. Oli Bartsch uploaded patch set 3 CR +1 V +1 04/13/23, 07:39

  7. Oli Bartsch voted on patch set 3 V +1 CR +1 04/13/23, 07:40

  8. core-ci voted on patch set 3 V +1 04/13/23, 07:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40547

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 04/13/23, 12:14

  10. Christian Kuhn merged patch set 4 04/13/23, 12:14