Review main Merged

78534[BUGFIX] Use frontend site-language specific CSP reporting endpoint

Oliver Hader CR +2 V +2 Normal +189 −7 updated 05/15/23, 09:16

Commit message

When having a site-language base URI like `/en/` the CSP reporting
endpoint was listening on `/@http-reporting`, but should have been
`/en/@http-reporting`, to correctly have the relevant site resolved.
As a consequence, CSP violations for those sites were not collected.

With this change, site-language specifics are considered as well.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Chris Müller +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Chris Müller +1
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Oliver Hader uploaded patch set 1 04/07/23, 10:56

  2. core-ci voted on patch set 1 V +1 04/07/23, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40328

  3. Oliver Hader updated the commit message in patch set 2 V +1 04/07/23, 11:18

  4. core-ci voted on patch set 2 V +1 04/07/23, 11:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40330

  5. Georg Ringer voted on patch set 2 V +1 CR +1 04/10/23, 15:53

  6. Chris Müller voted on patch set 2 V +1 CR +1 04/11/23, 08:54

  7. Oliver Hader voted on patch set 2 V +2 CR +2 04/11/23, 11:50

  8. Oliver Hader merged patch set 3 04/11/23, 11:50

  9. Andreas Kienast commented on patch set 3 04/11/23, 12:54

    PolicyProviderTest.php:29

    Should've been final
  10. Andreas Kienast commented on patch set 3 04/11/23, 12:56

    PolicyProviderTest.php:29 Reply

  11. Oliver Hader commented on patch set 3 05/15/23, 09:16

    PolicyProviderTest.php:29 Reply

    Thx!