78535[BUGFIX] Sanitize BackendUtility::titleAttribForPages()
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Benni Mack +1
Issues 2
Files 1
Review log 1619
-
Christian Kuhn uploaded patch set 1 04/07/23, 11:40
-
core-ci voted on patch set 1 V +1 04/07/23, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40331
-
Oliver Klee voted on patch set 1 CR +1 04/07/23, 11:59
-
Oliver Klee voted on patch set 1 CR 0 04/07/23, 11:59
-
Oliver Klee commented on patch set 1 04/07/23, 12:00
-
Christian Kuhn commented on patch set 1 04/10/23, 13:43
BackendUtility.php:1116Replyreturn early if there is no uid ... -
Oliver Klee commented on patch set 1 CR -1 04/10/23, 14:03
BackendUtility.php:1116ReplyHm, then we have a bug here in the change: We'll also return early if there is a (non-zero) UID set (which does not make sense at all to me). Maybe we need a test for this, I think. And I'd like to suggest this code instead: ```php if (!isset($row['uid'])) { ``` -
Christian Kuhn commented on patch set 1 04/10/23, 14:26
BackendUtility.php:1116Replycould you please provide the change that makes you more happy? from my point of view, the proposed solution is more than good enough. -
Christian Kuhn commented on patch set 1 CR -1 04/10/23, 14:42
BackendUtility.php:1116Replyscratch that, you're right. -
Christian Kuhn uploaded patch set 2
CR -1V +104/10/23, 14:46 -
core-ci voted on patch set 2 V +1 04/10/23, 14:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40411
-
Oliver Klee voted on patch set 2 CR +1 04/10/23, 14:56
-
Benni Mack updated the commit message in patch set 3
CR +1V +104/11/23, 09:49 -
Benni Mack voted on patch set 3 V +1 CR +1 04/11/23, 09:49
-
Oliver Klee voted on patch set 3 CR +1 04/11/23, 09:51
-
Jochen Roth voted on patch set 3 V +1 CR +1 04/11/23, 09:53
-
Christian Kuhn voted on patch set 3 V +2 CR +2 04/11/23, 09:56
-
Christian Kuhn merged patch set 4 04/11/23, 09:56
-
core-ci voted on patch set 3 V +1 04/11/23, 10:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40450
BackendUtility.php:1116