Review main Merged

78536[TASK] Drop help-block and optimize spacing in form engine

Benjamin Kott CR +2 V +2 Hard +119 −165 updated 04/12/23, 07:45

Commit message

The spacing for formengine elements have been improved.

The legacy .help-block was replaced with .form-text in
bootstrap 4.6, we are now finally adapting to this change
and replacing all leftover ocurrances of .help-block.

The legacy .control-label that was removed in bootstrap 4.6
with .form-label that will make a reappearance in bootstrap 5.3.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 49

Show 29 more files

Review log 1321

  1. Benjamin Kott uploaded patch set 1 04/07/23, 12:10

  2. core-ci voted on patch set 1 V -1 04/07/23, 12:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40332

  3. Benjamin Kott uploaded patch set 2 V -1 04/07/23, 13:57

  4. core-ci voted on patch set 2 V -1 04/07/23, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40342

  5. Benjamin Kott uploaded patch set 3 V -1 04/07/23, 17:23

  6. core-ci voted on patch set 3 V -1 04/07/23, 18:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40349

  7. Benjamin Kott uploaded patch set 4 V -1 04/07/23, 18:09

  8. core-ci voted on patch set 4 V -1 04/07/23, 19:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40351

  9. Benjamin Kott uploaded patch set 5 V -1 04/07/23, 20:18

  10. core-ci voted on patch set 5 V +1 04/07/23, 20:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40356

  11. Benjamin Kott uploaded patch set 6 V +1 04/11/23, 10:08

  12. core-ci voted on patch set 6 V +1 04/11/23, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40455

  13. Andreas Kienast voted on patch set 6 V +1 CR +1 04/11/23, 12:35

  14. Georg Ringer voted on patch set 6 V +2 CR +2 04/12/23, 06:23

  15. Andreas Kienast uploaded patch set 7 CR +1 V +1 04/12/23, 06:38

  16. Benjamin Kott uploaded patch set 8 04/12/23, 06:41

  17. core-ci voted on patch set 8 V +1 04/12/23, 06:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40486

  18. Benni Mack voted on patch set 8 V +1 CR +1 04/12/23, 07:23

  19. Andreas Kienast voted on patch set 8 V +2 CR +2 04/12/23, 07:27

  20. Andreas Kienast merged patch set 9 04/12/23, 07:27

  21. core-ci voted on patch set 7 V +1 04/12/23, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40485