Review main Merged

78541[BUGFIX] Use IntersectionObserver to determine if a tree is visible

Benjamin Kott CR +2 V +2 Easy +20 −18 updated 04/11/23, 07:36

Commit message

The problem with the current implementation is that it does not
consider that a tab may already be active but not visible initially.
In that case the `shown.bs.tab` event is never triggered.

We are moving to an observer that stays active until the element
is visible once, after that the observer for the tree is de-registered.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Torben Hansen +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Torben Hansen +1
    • Tymoteusz Motylewski +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1316

  1. Benjamin Kott uploaded patch set 1 04/07/23, 19:35

  2. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 04/07/23, 19:42

  3. core-ci voted on patch set 1 V +1 04/07/23, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40353

  4. Markus Klein updated the commit message in patch set 2 CR +1 V +1 04/07/23, 19:58

  5. Markus Klein voted on patch set 2 CR +1 04/07/23, 19:59

  6. core-ci voted on patch set 2 V +1 04/07/23, 20:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40355

  7. Tymoteusz Motylewski voted on patch set 2 V +1 CR +1 04/07/23, 20:23

  8. Torben Hansen voted on patch set 2 V +1 CR +1 04/08/23, 16:42

  9. Torben Hansen commented on patch set 2 04/08/23, 16:44

    Can this patch be backported to TYPO3 11.5 as well?
  10. Tymoteusz Motylewski updated the commit message in patch set 3 CR +1 V +1 04/08/23, 19:02

  11. Tymoteusz Motylewski commented on patch set 3 04/08/23, 19:02

    Reply

    at last we can try 😊
    added release for 11.5, please revote.
  12. Tymoteusz Motylewski voted on patch set 3 V +1 CR +1 04/08/23, 19:03

  13. core-ci voted on patch set 3 V +1 04/08/23, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40379

  14. Torben Hansen voted on patch set 3 V +1 CR +1 04/09/23, 03:30

  15. Andreas Kienast voted on patch set 3 V +2 CR +2 04/11/23, 07:36

  16. Andreas Kienast merged patch set 4 04/11/23, 07:36