Review main Merged

78544[TASK] Avoid PHP 8.2 deprecation messages in CSP backend module

Chris Müller CR +2 V +2 Easy +2 −2 updated 04/09/23, 14:15

Commit message

Replace "self" in callables by their first class callable syntax.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1216

  1. Chris Müller uploaded patch set 1 04/08/23, 08:56

  2. core-ci voted on patch set 1 V +1 04/08/23, 09:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40366

  3. Oliver Klee commented on patch set 1 04/08/23, 09:37

    Report.php:41

    I think we can use first-class callables in both cases: ```php array_map(self::toCamelCase(...), array_keys($meta)); ``` https://www.php.net/manual/en/functions.first_class_callable_syntax.php
  4. Chris Müller uploaded patch set 2 V +1 04/08/23, 12:59

  5. Chris Müller commented on patch set 2 04/08/23, 12:59

    That's a nice one, haven't thought about it.
  6. Chris Müller commented on patch set 2 04/08/23, 13:00

    Report.php:41 Reply

    Done
  7. core-ci voted on patch set 2 V +1 04/08/23, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40368

  8. Oliver Klee voted on patch set 2 CR +1 04/08/23, 13:16

  9. Oliver Hader uploaded patch set 3 CR +1 V +1 04/09/23, 07:36

  10. Oliver Hader voted on patch set 3 V +1 CR +1 04/09/23, 07:37

  11. Oliver Hader uploaded patch set 4 CR +1 V +1 04/09/23, 07:40

  12. Oliver Hader voted on patch set 4 V +1 CR +1 04/09/23, 07:42

  13. core-ci voted on patch set 3 V +1 04/09/23, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40389

  14. core-ci voted on patch set 4 V +1 04/09/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40390

  15. Stefan Bürk voted on patch set 4 V +2 CR +2 04/09/23, 14:15

  16. Stefan Bürk merged patch set 5 04/09/23, 14:15