Review main Merged

78545[TASK] Improve beuser templates

Benjamin Kott CR +2 V +2 Expert +1071 −976 updated 04/13/23, 13:00

Commit message

Templates were streamlined to provide the same experience
across the available modules. That means, record counter
headlines, and icons, are now placed the same way.

Template names were consolidated and are now sorting
according to their responsibility, regardless that everything
is pushed into the backend user controller.

BackendUser -> BackendUser
BackendUserGroup -> BackendUserGroup
Filemount -> Filemount

This structure was already present in the partials
folder and was adapted also for the templates.

Partials that would just move information around without
a greater benefit was removed and information was moved
to the main template. Bloating the amount partials only
makes it harder to get an overview of the current structure
and the template.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jasmina Ließmann +1
    • core-ci +1 CI

Issues 1

Files 40

Show 20 more files

Review log 3244

Show 1219 earlier messages
  1. Benjamin Kott uploaded patch set 1 04/08/23, 13:11

  2. Benjamin Kott updated the commit message in patch set 2 04/08/23, 13:12

  3. Benjamin Kott updated the commit message in patch set 3 04/08/23, 13:14

  4. Benjamin Kott updated the commit message in patch set 4 04/08/23, 13:20

  5. core-ci voted on patch set 1 V -1 04/08/23, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40369

  6. core-ci voted on patch set 2 V -1 04/08/23, 13:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40370

  7. core-ci voted on patch set 3 V -1 04/08/23, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40371

  8. core-ci voted on patch set 4 V -1 04/08/23, 13:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40373

  9. Benjamin Kott uploaded patch set 5 V -1 04/08/23, 13:58

  10. core-ci voted on patch set 5 V -1 04/08/23, 14:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40375

  11. Benjamin Kott uploaded patch set 6 V -1 04/08/23, 14:31

  12. core-ci voted on patch set 6 V -1 04/08/23, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40378

  13. Benjamin Kott uploaded patch set 7 V -1 04/09/23, 08:37

  14. core-ci voted on patch set 7 V +1 04/09/23, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40394

  15. Georg Ringer commented on patch set 7 04/12/23, 04:48

    should we really remove the html tag? looks wrong to me a bit
  16. Andreas Kienast commented on patch set 7 04/12/23, 06:07

    Reply

    It's already "missing" in other partials, so at least it's streamlined now.
  17. Markus Klein commented on patch set 7 04/12/23, 12:44

    Reply

    Please keep the HTML tags. any editor with xml-validation (like phpstorm) goes red, deep red, on all templates otherwise.
  18. Benjamin Kott uploaded patch set 8 V +1 04/12/23, 16:49

  19. Benjamin Kott commented on patch set 8 04/12/23, 16:57

    Reply

    As mentioned, the usage is random and we are actually talking about document fragements and not documents. The HTML tag indicates the root of a document, partials etc. are not even complete valid nested HTML. I´ve added the namespace imports again and removed them from the global scope, because lolli mentioned this in another patch. This seems to be an IDE configuration issue to me, and i prefer to not bloat the templates with unessesary markup that gets parsed out anyways.
  1. core-ci voted on patch set 8 V +1 04/12/23, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40523

  2. Christian Kuhn voted on patch set 8 CR -1 04/12/23, 17:25

  3. Christian Kuhn commented on patch set 8 04/12/23, 17:29

    please keep (or add if missing) the <html tag in all templates, including the used xmlns namespaces: this is valid html, it helps IDE plugins, and auto-completion of VH arguments. please avoid using the {namespace} syntax.
  4. Jasmina Ließmann uploaded patch set 9 CR -1 V +1 04/12/23, 20:50

  5. Jasmina Ließmann uploaded patch set 10 04/12/23, 20:57

  6. core-ci voted on patch set 9 V +1 04/12/23, 21:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40529

  7. core-ci voted on patch set 10 V +1 04/12/23, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40530

  8. Jasmina Ließmann commented on patch set 10 V -1 04/12/23, 21:32

    List.html:43

    When I select multiple backend user groups and click on the button 'Compare backend usergroups', I get an error in file '\typo3\sysext\beuser\Classes\Service\UserInformationService.php' at line 235.
  9. Jasmina Ließmann commented on patch set 10 04/12/23, 21:32

    I love the new style of comparison list! Thanks for taking care of it! Some thoughts about the backend user details: - The contents in the columns below the table still look a little wild. How about if all areas are presented in two columns instead of the three columns in the first row? - If there is no configuration in a section, only the headings are displayed (sometimes several below each other, e.g. for admin accounts or backend users who obtain all settings from their groups). Perhaps we can add a note for each section where there is no configuration?
  10. Jasmina Ließmann uploaded patch set 11 V +1 04/12/23, 21:34

  11. Jasmina Ließmann commented on patch set 11 CR -1 04/12/23, 21:37

    Reply

    I agree with the others to keep the html tag.
  12. core-ci voted on patch set 11 V +1 04/12/23, 21:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40534

  13. Benjamin Kott commented on patch set 11 04/13/23, 06:02

    Reply

    I only corrected styles in this area, it was like this when I touched it. I am aware of extra margins on the bottom - not the scope of this patch to find a solution to this. This needs another round of dedicated styling of contents nested in tables.
  14. Benjamin Kott commented on patch set 11 04/13/23, 06:03

    Reply

    Problem here is that the partials are used in table and detail view.
  15. Benjamin Kott uploaded patch set 12 CR -1 V +1 04/13/23, 07:04

  16. Benjamin Kott commented on patch set 12 04/13/23, 07:06

    Reply

    Done
  17. Benjamin Kott commented on patch set 12 04/13/23, 07:06

    Reply

    Ack
  18. Benjamin Kott commented on patch set 12 04/13/23, 07:08

    List.html:43 Reply

    i cannot reproduce the error
  19. core-ci voted on patch set 12 V +1 04/13/23, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40546

  20. Benjamin Kott commented on patch set 12 04/13/23, 09:17

  21. Andreas Kienast commented on patch set 12 04/13/23, 12:53

    Minor issue: when comparing two backend users, the right hand TSconfig tree has no "outer" line. This is fixed when zooming in to 110% or 150%.
  22. Andreas Kienast commented on patch set 12 04/13/23, 12:58

    Reply

    This is no issue introduced by this patch. The affected TSconfig tree has only one direct <li> ancestor of the <ul> and therefore the tree behaves correctly as defined per CSS.
  23. Jasmina Ließmann voted on patch set 12 V +1 CR +1 04/13/23, 12:58

  24. Christian Kuhn voted on patch set 12 V +2 CR +2 04/13/23, 13:00

  25. Christian Kuhn merged patch set 13 04/13/23, 13:00