78555[BUGFIX] Apply inline icon styles with nonce attribute
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/TypeScript/backend/element/icon-element.ts2+2 −3
- Build/Sources/TypeScript/backend/element/spinner-element.ts+4 −3
- Build/Sources/TypeScript/core/lit-helper.ts+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/element/icon-element.js+2 −4
- typo3/sysext/backend/Resources/Public/JavaScript/element/spinner-element.js+4 −4
Review log 1823
-
Oliver Hader uploaded patch set 1 04/10/23, 17:47
-
Oliver Hader uploaded patch set 2 04/10/23, 17:51
-
core-ci voted on patch set 1 V +1 04/10/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40418
-
core-ci voted on patch set 2 V +1 04/10/23, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40419
-
Andreas Kienast voted on patch set 2 V +1 CR +1 04/11/23, 05:59
-
Andreas Kienast commented on patch set 2 V 0 CR -1 04/11/23, 06:31
on it -
Andreas Kienast uploaded patch set 3
CR -1V +104/11/23, 06:33 -
Andreas Kienast uploaded patch set 4 04/11/23, 06:34
-
core-ci voted on patch set 4 V +1 04/11/23, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40440
-
Oliver Hader commented on patch set 4 CR +1 04/11/23, 06:57
Nice, I did not even realize it is ShadowDOM already and was just focussed the `<style>` tag. This version looks much cleaner, thx! -
Andreas Kienast voted on patch set 4 V +1 CR +1 04/11/23, 06:58
-
Benjamin Kott voted on patch set 4 V +1 CR +1 04/11/23, 07:06
-
Benjamin Kott voted on patch set 4 V 0 CR 0 04/11/23, 07:06
-
core-ci voted on patch set 3 V +1 04/11/23, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40439
-
Andreas Kienast commented on patch set 4 V 0 CR -1 04/11/23, 07:18
For whatever reason this fails when the components are used in nested web components. Will revert back to change set 2. -
Andreas Kienast uploaded patch set 5
CR +1V +104/11/23, 07:18 -
Benjamin Kott commented on patch set 4 04/11/23, 07:19
icon-element.ts:33static styles was removed due to a compiling error with deep nested webcomponents see https://forge.typo3.org/attachments/37603 -
Andreas Kienast voted on patch set 5 V +1 CR +1 04/11/23, 07:19
-
Benjamin Kott commented on patch set 5 04/11/23, 07:22
icon-element.ts:33ReplyDone -
Benjamin Kott voted on patch set 5 V +1 CR +1 04/11/23, 07:23
-
core-ci voted on patch set 5 V +1 04/11/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40443
-
Andreas Kienast voted on patch set 5 V +2 CR +2 04/11/23, 07:30
-
Andreas Kienast merged patch set 6 04/11/23, 07:30