Review main Merged

78555[BUGFIX] Apply inline icon styles with nonce attribute

Oliver Hader CR +2 V +2 Easy +14 −16 updated 04/11/23, 07:30

Commit message

Since issue #100270 some icons are not rendered anymore in the
backend when having a strict `style-src` CSP directive enabled
(not allowing `'unsafe-inline'`, using a `'nonce-...'` instead).

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 1823

  1. Oliver Hader uploaded patch set 1 04/10/23, 17:47

  2. Oliver Hader uploaded patch set 2 04/10/23, 17:51

  3. core-ci voted on patch set 1 V +1 04/10/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40418

  4. core-ci voted on patch set 2 V +1 04/10/23, 17:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40419

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 04/11/23, 05:59

  6. Andreas Kienast commented on patch set 2 V 0 CR -1 04/11/23, 06:31

    on it
  7. Andreas Kienast uploaded patch set 3 CR -1 V +1 04/11/23, 06:33

  8. Andreas Kienast uploaded patch set 4 04/11/23, 06:34

  9. core-ci voted on patch set 4 V +1 04/11/23, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40440

  10. Oliver Hader commented on patch set 4 CR +1 04/11/23, 06:57

    Nice, I did not even realize it is ShadowDOM already and was just focussed the `<style>` tag. This version looks much cleaner, thx!
  11. Andreas Kienast voted on patch set 4 V +1 CR +1 04/11/23, 06:58

  12. Benjamin Kott voted on patch set 4 V +1 CR +1 04/11/23, 07:06

  13. Benjamin Kott voted on patch set 4 V 0 CR 0 04/11/23, 07:06

  14. core-ci voted on patch set 3 V +1 04/11/23, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40439

  15. Andreas Kienast commented on patch set 4 V 0 CR -1 04/11/23, 07:18

    For whatever reason this fails when the components are used in nested web components. Will revert back to change set 2.
  16. Andreas Kienast uploaded patch set 5 CR +1 V +1 04/11/23, 07:18

  17. Benjamin Kott commented on patch set 4 04/11/23, 07:19

    icon-element.ts:33

    static styles was removed due to a compiling error with deep nested webcomponents see https://forge.typo3.org/attachments/37603
  18. Andreas Kienast voted on patch set 5 V +1 CR +1 04/11/23, 07:19

  19. Benjamin Kott commented on patch set 5 04/11/23, 07:22

    icon-element.ts:33 Reply

    Done
  20. Benjamin Kott voted on patch set 5 V +1 CR +1 04/11/23, 07:23

  21. core-ci voted on patch set 5 V +1 04/11/23, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40443

  22. Andreas Kienast voted on patch set 5 V +2 CR +2 04/11/23, 07:30

  23. Andreas Kienast merged patch set 6 04/11/23, 07:30