Review 11.5 Merged

78556[BUGFIX] Use IntersectionObserver to determine if a tree is visible

Andreas Kienast CR +2 V +2 Easy +20 −18 updated 04/11/23, 08:07

Commit message

The problem with the current implementation is that it does not
consider that a tab may already be active but not visible initially.
In that case the `shown.bs.tab` event is never triggered.

We are moving to an observer that stays active until the element
is visible once, after that the observer for the tree is de-registered.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Andreas Kienast uploaded patch set 1 04/11/23, 07:42

  2. core-ci voted on patch set 1 V +1 04/11/23, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40444

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 04/11/23, 08:07

  4. Andreas Kienast merged patch set 2 04/11/23, 08:07