Review 11.5 Merged

78558[BUGFIX] Sanitize BackendUtility::titleAttribForPages()

Christian Kuhn CR +2 V +2 Easy +3 −0 updated 04/11/23, 10:05

Commit message

When the "Access" module is called without a selected
page, the root page icon rendering triggers a PHP 8.0
array access warning.

This was triggered by the refactoring with #100454, but
is a general issue of the method, which is why the patch
should go to 11.5 as well.

The patch sanitizes $row['uid']. Other parts of the
method access further array keys without fallback,
but those should be fine - at least for now - since
this is about 'pages', and if there is a uid, the
other fields are probably provided as well.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Christian Kuhn uploaded patch set 1 04/11/23, 09:55

  2. core-ci voted on patch set 1 V +1 04/11/23, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40451

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 04/11/23, 10:05

  4. Christian Kuhn merged patch set 2 04/11/23, 10:05