Review main Merged

78564[BUGFIX] Assign the title attribute directly to icons or the parent

Benjamin Kott CR +2 V +2 Hard +149 −125 updated 04/21/23, 13:04

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 19

Review log 1523

  1. Benjamin Kott uploaded patch set 1 04/11/23, 13:03

  2. Benjamin Kott uploaded patch set 2 04/11/23, 13:15

  3. core-ci voted on patch set 1 V -1 04/11/23, 13:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40465

  4. core-ci voted on patch set 2 V -1 04/11/23, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40469

  5. Benjamin Kott uploaded patch set 3 V -1 04/12/23, 06:35

  6. core-ci voted on patch set 3 V -1 04/12/23, 06:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40484

  7. Benjamin Kott uploaded patch set 4 V -1 04/12/23, 11:16

  8. core-ci voted on patch set 4 V -1 04/12/23, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40501

  9. Markus Klein commented on patch set 4 04/12/23, 11:36

    AdvancedOptions.html:5

    why removing the html here? It helps IDEs to identify the fluid correctly
  10. Markus Klein commented on patch set 4 CR -1 04/12/23, 11:39

    Actually I think it's really wrong to remove namespace declarations inside html/xml files. The whole point of Fluid was to be mostly xml-valid (compared to other engines).
  11. Benjamin Kott uploaded patch set 5 CR -1 V -1 04/12/23, 12:45

  12. core-ci voted on patch set 5 V -1 04/12/23, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40505

  13. Benjamin Kott commented on patch set 5 04/13/23, 07:12

    Reply

    Done

    AdvancedOptions.html:5 Reply

    Done
  14. Benjamin Kott uploaded patch set 6 V -1 04/21/23, 10:04

  15. Benjamin Kott uploaded patch set 7 04/21/23, 10:39

  16. core-ci voted on patch set 6 V -1 04/21/23, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41026

  17. core-ci voted on patch set 7 V -1 04/21/23, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41027

  18. Andreas Kienast uploaded patch set 8 V -1 04/21/23, 11:00

  19. core-ci voted on patch set 8 V +1 04/21/23, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41028

  20. Andreas Kienast voted on patch set 8 V +1 CR +1 04/21/23, 11:25

  21. Markus Klein voted on patch set 8 V +1 CR +1 04/21/23, 12:08

  22. Andreas Kienast voted on patch set 8 V +2 CR +2 04/21/23, 13:04

  23. Andreas Kienast merged patch set 9 04/21/23, 13:04