Review 11.5 Merged

78571[BUGFIX] Fix page reloading on click on preview button (again)

Andreas Kienast CR +2 V +2 Easy +11 −4 updated 04/12/23, 06:22

Commit message

The changes introduced in #93706 broke the preview button functionality
in multidomain setups. When first previewing the page in one page tree
and then clicking the preview link in the page tree of a different
domain, a DOMException due to a cross origin error would be triggered
in JavaScript, because it is not allowed to access the constructor of
a window object from a different context.

The thrown DOMException is now properly caught.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 04/12/23, 06:06

  2. core-ci voted on patch set 1 V +1 04/12/23, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40483

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 04/12/23, 06:22

  4. Andreas Kienast merged patch set 2 04/12/23, 06:22