Review main Merged

78592[BUGFIX] Allow multiple CSS files in CKEditor 5

Andreas Kienast CR +2 V +2 Normal +159 −20 updated 04/13/23, 06:13

Commit message

With the migration to CKEditor 5, `config.contentsCss` was degraded to
allow a single file only in CKEditor itself. This patch introduces a
migration, converting `config.contentsCss` to an array.

Documentation and examples are adjusted accordingly.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 2430

Show 35 earlier messages
  1. Andreas Kienast uploaded patch set 1 04/12/23, 07:55

  2. Andreas Kienast uploaded patch set 2 04/12/23, 08:03

  3. core-ci voted on patch set 1 V -1 04/12/23, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40487

  4. core-ci voted on patch set 2 V +1 04/12/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40488

  5. Markus Klein voted on patch set 2 CR +1 04/12/23, 08:48

  1. Benjamin Kott commented on patch set 2 CR -1 04/12/23, 09:10

    RichTextElement.php:130

    this can be a string, or an array
  2. Benjamin Kott commented on patch set 2 V -1 04/12/23, 09:13

    ResourceController.php:57

    keep the controller as is, just call it multiple times in richtext element
  3. Markus Klein commented on patch set 2 04/12/23, 09:15

    RichTextElement.php:130 Reply

    it is cast to an array, so it will always be one. (the string will be automatically changed to array)
  4. Benjamin Kott commented on patch set 2 04/12/23, 09:18

    RichTextElement.php:130 Reply

  5. Andreas Kienast commented on patch set 2 04/12/23, 09:24

    ResourceController.php:57 Reply

    Ain't it better to save HTTP requests instead?
  6. Benjamin Kott commented on patch set 2 04/12/23, 09:43

    ResourceController.php:57 Reply

    you increase the complexity of the endpoint, i would prefer to have it more simple
  7. Benjamin Kott commented on patch set 2 04/12/23, 09:44

    ResourceController.php:57 Reply

    it´s also called stylesheetAction and now processes multiple ones.
  8. Benjamin Kott commented on patch set 2 04/12/23, 09:46

    RichTextElement.php:130 Reply

    that one was resolved by accident. please ensure the config we are processing is in a streamlined format. so please add a test for this and add the casting / migration to the CKEditor5 Migration
  9. Andreas Kienast uploaded patch set 3 CR +1 V +1 04/12/23, 10:16

  10. Andreas Kienast uploaded patch set 4 04/12/23, 10:17

  11. core-ci voted on patch set 3 V -1 04/12/23, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40492

  12. core-ci voted on patch set 4 V -1 04/12/23, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40493

  13. Benjamin Kott voted on patch set 2 V 0 CR 0 04/12/23, 11:05

  14. Benjamin Kott commented on patch set 4 04/12/23, 11:05

    RichTextElement.php:130 Reply

    Done
  15. Benjamin Kott commented on patch set 4 04/12/23, 11:06

    ResourceController.php:57 Reply

    Done
  16. Benjamin Kott commented on patch set 4 04/12/23, 11:07

    CKEditor5Migrator.php:557

    do we need to check trimmed values?
  17. Andreas Kienast uploaded patch set 5 V -1 04/12/23, 11:13

  18. Andreas Kienast commented on patch set 5 04/12/23, 11:14

    CKEditor5Migrator.php:557 Reply

    Ack
  19. core-ci voted on patch set 5 V -1 04/12/23, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40500

  20. Andreas Kienast uploaded patch set 6 V -1 04/12/23, 11:22

  21. core-ci voted on patch set 6 V +1 04/12/23, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40502

  22. Oliver Hader commented on patch set 6 CR +1 04/12/23, 12:13

    Good one!
  23. Benjamin Kott voted on patch set 6 V +1 CR +1 04/13/23, 06:11

  24. Andreas Kienast voted on patch set 6 V +2 CR +2 04/13/23, 06:13

  25. Andreas Kienast merged patch set 7 04/13/23, 06:13