78592[BUGFIX] Allow multiple CSS files in CKEditor 5
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Hader +1
- Benjamin Kott +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Classes/Configuration/CKEditor5Migrator.php2+25 −0
- typo3/sysext/core/Tests/Unit/Configuration/CKEditor5MigratorTest.php+93 −0
- typo3/sysext/core/Tests/Unit/Configuration/RichtextTest.php+30 −10
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php5+5 −5
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/Base.yaml+2 −1
- typo3/sysext/rte_ckeditor/Documentation/Configuration/Examples.rst+2 −1
- typo3/sysext/rte_ckeditor/Documentation/Configuration/Reference.rst+2 −3
Review log 2430
Show 35 earlier messages
-
Andreas Kienast uploaded patch set 1 04/12/23, 07:55
-
Andreas Kienast uploaded patch set 2 04/12/23, 08:03
-
core-ci voted on patch set 1 V -1 04/12/23, 08:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40487
-
core-ci voted on patch set 2 V +1 04/12/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40488
-
Markus Klein voted on patch set 2 CR +1 04/12/23, 08:48
-
Benjamin Kott commented on patch set 2 CR -1 04/12/23, 09:10
-
Benjamin Kott commented on patch set 2 V -1 04/12/23, 09:13
ResourceController.php:57keep the controller as is, just call it multiple times in richtext element -
Markus Klein commented on patch set 2 04/12/23, 09:15
RichTextElement.php:130Replyit is cast to an array, so it will always be one. (the string will be automatically changed to array) -
Benjamin Kott commented on patch set 2 04/12/23, 09:18
RichTextElement.php:130ReplyDo migration in https://github.com/TYPO3/typo3/blob/main/typo3/sysext/core/Classes/Configuration/CKEditor5Migrator.php to ensure it´s always an array and add an test -
Andreas Kienast commented on patch set 2 04/12/23, 09:24
ResourceController.php:57ReplyAin't it better to save HTTP requests instead? -
Benjamin Kott commented on patch set 2 04/12/23, 09:43
ResourceController.php:57Replyyou increase the complexity of the endpoint, i would prefer to have it more simple -
Benjamin Kott commented on patch set 2 04/12/23, 09:44
ResourceController.php:57Replyit´s also called stylesheetAction and now processes multiple ones. -
Benjamin Kott commented on patch set 2 04/12/23, 09:46
RichTextElement.php:130Replythat one was resolved by accident. please ensure the config we are processing is in a streamlined format. so please add a test for this and add the casting / migration to the CKEditor5 Migration -
Andreas Kienast uploaded patch set 3
CR +1V +104/12/23, 10:16 -
Andreas Kienast uploaded patch set 4 04/12/23, 10:17
-
core-ci voted on patch set 3 V -1 04/12/23, 10:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40492
-
core-ci voted on patch set 4 V -1 04/12/23, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40493
-
Benjamin Kott voted on patch set 2 V 0 CR 0 04/12/23, 11:05
-
Benjamin Kott commented on patch set 4 04/12/23, 11:05
RichTextElement.php:130ReplyDone -
Benjamin Kott commented on patch set 4 04/12/23, 11:06
ResourceController.php:57ReplyDone -
Benjamin Kott commented on patch set 4 04/12/23, 11:07
CKEditor5Migrator.php:557do we need to check trimmed values? -
Andreas Kienast uploaded patch set 5
V -104/12/23, 11:13 -
Andreas Kienast commented on patch set 5 04/12/23, 11:14
CKEditor5Migrator.php:557ReplyAck -
core-ci voted on patch set 5 V -1 04/12/23, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40500
-
Andreas Kienast uploaded patch set 6
V -104/12/23, 11:22 -
core-ci voted on patch set 6 V +1 04/12/23, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40502
-
Oliver Hader commented on patch set 6 CR +1 04/12/23, 12:13
Good one! -
Benjamin Kott voted on patch set 6 V +1 CR +1 04/13/23, 06:11
-
Andreas Kienast voted on patch set 6 V +2 CR +2 04/13/23, 06:13
-
Andreas Kienast merged patch set 7 04/13/23, 06:13
RichTextElement.php:130