Review main Merged

78593[BUGFIX] ckeditor: Do not update source element on document change

Andreas Kienast CR +2 V +2 Easy +1 −2 updated 04/12/23, 14:25

Commit message

The change in #99669 introduced an update of the source element bound to
the ckeditor instance. Unfortunately, this leads to a recursion loop
when the "Source view" is active and the save action in FormEngine is
invoked.

Apparently, updating the source element is not required and is therefore
removed again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 68

  1. Andreas Kienast uploaded patch set 1 04/12/23, 09:41

  2. core-ci voted on patch set 1 V +1 04/12/23, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40490

  3. Tymoteusz Motylewski commented on patch set 1 04/12/23, 10:38

    sth wrong with the sentence
  4. Benni Mack updated the commit message in patch set 2 V +1 04/12/23, 11:24

  5. Benni Mack commented on patch set 2 V +1 CR +1 04/12/23, 11:24

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 04/12/23, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40503

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 04/12/23, 14:25

  8. Andreas Kienast merged patch set 3 04/12/23, 14:25