Review main Merged

78595[BUGFIX] Use associative keys in AbstractContentPagePositionMap

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 04/12/23, 11:24

Commit message

The controller called when moving (content) elements in
list module triggers an undefined array key warning.
The code has not been adapted to the 'label' and 'value'
item keys introduced with #99739. Do this now.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 04/12/23, 10:55

  2. core-ci voted on patch set 1 V +1 04/12/23, 11:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40495

  3. Benni Mack voted on patch set 1 V +1 CR +1 04/12/23, 11:20

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 04/12/23, 11:23

  5. Oli Bartsch merged patch set 2 04/12/23, 11:24