Review main Merged

78598[BUGFIX] Correct link in PageMovingPagePositionMap

Christian Kuhn CR +2 V +2 Easy +32 −10 updated 04/12/23, 15:19

Commit message

Repositioning a content element to a different page
using the list module "Re-position content element"
view fails with a broken "backend-in-backend" link.

The patch avoids linkThisScript() by handing the request
around and creates the url using the UriBuilder instead.

Note the construct is one of the few left over controllers
that have not been refactored yet. This should happen in
v13, together with re-thinking the view along the way.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Christian Kuhn uploaded patch set 1 04/12/23, 14:50

  2. Christian Kuhn uploaded patch set 2 04/12/23, 14:53

  3. core-ci voted on patch set 1 V +1 04/12/23, 14:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40509

  4. Andreas Kienast voted on patch set 2 V +1 CR +1 04/12/23, 15:08

  5. core-ci voted on patch set 2 V +1 04/12/23, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40510

  6. Benni Mack voted on patch set 2 V +2 CR +2 04/12/23, 15:19

  7. Benni Mack merged patch set 3 04/12/23, 15:19