Review main Abandoned

78599[BUGFIX] Secure access to form settings in FormManagerController

Oli Bartsch CR 0 V 0 Easy +5 −5 updated 04/15/23, 09:24

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1417

  1. Oli Bartsch uploaded patch set 1 04/12/23, 15:13

  2. Benni Mack updated the commit message in patch set 2 04/12/23, 15:18

  3. core-ci voted on patch set 1 V +1 04/12/23, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40511

  4. core-ci voted on patch set 2 V +1 04/12/23, 15:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40512

  5. Christian Kuhn commented on patch set 2 CR -1 04/12/23, 15:58

    I don't think this is the correct fix, the issue is below in TS parser. I had a rough look yesterday, and will provide some bugfix soon.
  6. Oli Bartsch commented on patch set 2 04/12/23, 16:44

    Reply

    Those array accesses should be secured anyway..
  7. Oliver Klee voted on patch set 2 CR +1 04/12/23, 18:50

  8. Christian Kuhn commented on patch set 2 04/12/23, 18:52

    Reply Unresolved

    I disagree. We should have an early exception at least on the main array instead. We'd otherwise hide crucial issues.
  9. Guido Schmechel commented on patch set 2 04/12/23, 20:29

    Small typo: FormManagerController
  10. André Buchmann uploaded patch set 3 CR +1 V +1 04/13/23, 13:35

  11. André Buchmann commented on patch set 3 V +1 CR +1 04/13/23, 13:36

    Reply

    Fixed commit message
  12. core-ci voted on patch set 3 V +1 04/13/23, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40570

  13. André Buchmann commented on patch set 3 V -1 CR 0 04/13/23, 13:47

    Form Module loads with this fix, but the JS throws an error and it is not possible to create a form caught (in promise) TypeError: Cannot read properties of undefined (reading 'name') at loadModule (java-script-item-processor.js?bust=fbd69b824b1e392bae1ccf829eaffb963e31fc07:13:346) at Helper.dispatchFormManager (helper.js?bust=fbd69b824b1e392bae1ccf829eaffb963e31fc07:13:328) at java-script-item-processor.js?bust=fbd69b824b1e392bae1ccf829eaffb963e31fc07:13:1381 at java-script-item-processor.js?bust=fbd69b824b1e392bae1ccf829eaffb963e31fc07:13:1559 at Array.map (<anonymous>) at java-script-item-processor.js?bust=fbd69b824b1e392bae1ccf829eaffb963e31fc07:13:1549 l
  14. Christian Kuhn commented on patch set 3 04/13/23, 14:56

    Reply Unresolved

    Yes. The issue is deeper: TS is not properly calculated. The sanitation does not help with this. I'll have a look at this soon.
  15. Christian Kuhn commented on patch set 3 04/15/23, 08:58

    i'll abandon here and will push a new approach.
  16. Christian Kuhn abandoned the change 04/15/23, 08:58

  17. Christian Kuhn commented on patch set 3 04/15/23, 09:24