Review main Merged

78601[TASK] Separate move page + move content element

Benni Mack CR +2 V +2 Hard +299 −107 updated 04/12/23, 17:38

Commit message

This change splits up moving of a page into a
"move_page" route / controller, and the
"move_element" for tt_content elements,
allowing to further adjust each of the views
separately.

Some link handling is fixed along the way, avoiding
further broken uses of GU::linkThisScript().

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 811

  1. Benni Mack uploaded patch set 1 04/12/23, 15:27

  2. Benni Mack updated the commit message in patch set 2 04/12/23, 15:29

  3. core-ci voted on patch set 2 V +1 04/12/23, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40515

  4. core-ci voted on patch set 1 V +1 04/12/23, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40514

  5. Christian Kuhn commented on patch set 2 CR -1 04/12/23, 16:06

    nice. i'll fiddle with some details and will push soon.
  6. Christian Kuhn uploaded patch set 3 CR -1 V +1 04/12/23, 17:22

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 04/12/23, 17:24

  8. core-ci voted on patch set 3 V +1 04/12/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40526

  9. Stefan Bürk voted on patch set 3 CR +1 04/12/23, 17:30

  10. Stefan Bürk voted on patch set 3 V +2 CR +2 04/12/23, 17:38

  11. Stefan Bürk merged patch set 4 04/12/23, 17:38