Review main Merged

78602[BUGFIX] Fix return type in RequestWrapper

Oli Bartsch CR +2 V +2 Easy +6 −6 updated 04/12/23, 19:24

Commit message

In case TypoScript conditions are evaluated in
the backend, e.g. in extbase modules, usage
of `getPageArguments()` might led to exceptions,
because in backend context, no PageArguments
object is available.

This is now fixed and a corresponding example
is adjusted.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 810

  1. Oli Bartsch uploaded patch set 1 04/12/23, 15:51

  2. Christian Kuhn commented on patch set 1 CR -1 04/12/23, 15:59

    -1 for now. will review soon.
  3. core-ci voted on patch set 1 V -1 04/12/23, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40516

  4. Oli Bartsch uploaded patch set 2 CR -1 V -1 04/12/23, 16:45

  5. core-ci voted on patch set 2 V +1 04/12/23, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40522

  6. Oli Bartsch commented on patch set 2 CR -1 04/12/23, 16:55

    waiting for lolli to review
  7. Christian Kuhn voted on patch set 2 V +1 CR +1 04/12/23, 17:53

  8. Oli Bartsch commented on patch set 2 CR 0 04/12/23, 19:21

    Reply

    Done
  9. Stefan Bürk voted on patch set 2 V +2 CR +2 04/12/23, 19:24

  10. Stefan Bürk merged patch set 3 04/12/23, 19:24