Review main Merged

78609[TASK] Have request in FormEngine

Christian Kuhn CR +2 V +2 Normal +193 −37 updated 04/13/23, 12:39

Commit message

Some details of FormEngine still directly or
indirectly access request data from globals.

To change this, controllers should hand over the
current request to FormEngine.

The patch establishes this for all controllers and adds
a (deprecated) fallback to $GLOBALS['TYPO3_REQUEST'].

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 24

Show 4 more files

Review log 1117

  1. Christian Kuhn uploaded patch set 1 04/12/23, 20:14

  2. Christian Kuhn uploaded patch set 2 04/12/23, 20:58

  3. core-ci voted on patch set 1 V -1 04/12/23, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40528

  4. core-ci voted on patch set 2 V -1 04/12/23, 21:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40531

  5. Christian Kuhn uploaded patch set 3 V -1 04/13/23, 10:36

  6. Christian Kuhn uploaded patch set 4 04/13/23, 10:48

  7. core-ci voted on patch set 3 V -1 04/13/23, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40560

  8. core-ci voted on patch set 4 V +1 04/13/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40561

  9. Christian Kuhn uploaded patch set 5 V +1 04/13/23, 11:22

  10. Christian Kuhn updated the commit message in patch set 6 04/13/23, 11:23

  11. core-ci voted on patch set 5 V +1 04/13/23, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40562

  12. core-ci voted on patch set 6 V +1 04/13/23, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40563

  13. Andreas Kienast voted on patch set 6 V +1 CR +1 04/13/23, 12:21

  14. Stefan Bürk voted on patch set 6 CR +1 04/13/23, 12:27

  15. Stefan Bürk voted on patch set 6 V +1 04/13/23, 12:38

  16. Christian Kuhn voted on patch set 6 V +2 CR +2 04/13/23, 12:39

  17. Christian Kuhn merged patch set 7 04/13/23, 12:39