Review main Merged

78610[TASK] Deprecate two BackendUtility methods

Benni Mack CR +2 V +2 Normal +190 −30 updated 04/14/23, 17:49

Commit message

The BackendUtility methods getThumbnailUrl()
and getLinkToDataHandlerAction() are deprecated as
they are just wrapper methods with limited extra
value. The functionality can easily be implementend
by using the corresponding APIs directly.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1013

  1. Benni Mack uploaded patch set 1 04/12/23, 21:15

  2. core-ci voted on patch set 1 V -1 04/12/23, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40532

  3. Benni Mack uploaded patch set 2 V -1 04/13/23, 08:03

  4. core-ci voted on patch set 2 V +1 04/13/23, 08:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40551

  5. Andreas Kienast commented on patch set 2 04/13/23, 08:48

    GridColumnItem.php:128

    I thinks it's cleaner to pass the URL arguments as 2nd argument to `buildUriFromRoute()`
  6. Oli Bartsch commented on patch set 2 04/14/23, 13:42

    I'm on it
  7. Oli Bartsch uploaded patch set 3 V +1 04/14/23, 14:45

  8. Oli Bartsch uploaded patch set 4 04/14/23, 14:46

  9. Oli Bartsch commented on patch set 4 04/14/23, 14:46

    GridColumnItem.php:128 Reply

    Done
  10. core-ci voted on patch set 4 V +1 04/14/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40629

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 04/14/23, 15:15

  12. Stefan Bürk voted on patch set 4 V +2 CR +2 04/14/23, 17:49

  13. Stefan Bürk merged patch set 5 04/14/23, 17:49