Review main Merged

78616[BUGFIX] Allow different navigation component for sub modules

Oli Bartsch CR +2 V +2 Easy +3 −1 updated 04/13/23, 12:06

Commit message

To set a different navigation component for a sub module,
"inheritNavigationComponentFromMainModule" must
be disabled (setting it to FALSE in the configuration).

Previously setting this property skipped the navigation
component evaluation. This is now fixed.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 04/13/23, 10:25

  2. core-ci voted on patch set 1 V +1 04/13/23, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40559

  3. Jochen Roth voted on patch set 1 V +1 CR +1 04/13/23, 11:21

  4. Benni Mack voted on patch set 1 V +1 CR +1 04/13/23, 11:25

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 04/13/23, 12:06

  6. Oli Bartsch merged patch set 2 04/13/23, 12:06