Review main Merged

78619[TASK] Prepare FormDataCompiler towards DI

Christian Kuhn CR +2 V +2 Hard +279 −208 updated 04/14/23, 08:42

Commit message

FormDataCompiler pollutes __construct(), making
it impossible to be injected.

The patch changes compile() to receive the
FormDataGroup, which will free the constructor
of this class in v13.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 1014

  1. Christian Kuhn uploaded patch set 1 04/13/23, 13:20

  2. core-ci voted on patch set 1 V +1 04/13/23, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40568

  3. Christian Kuhn uploaded patch set 2 V +1 04/13/23, 14:52

  4. core-ci voted on patch set 2 V +1 04/13/23, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40573

  5. Oli Bartsch commented on patch set 2 04/13/23, 15:40

    Deprecation-100581-AvoidConstructorArgumentInFormDataCompiler.rst:49

    Should be `MyDataGroup::class`
  6. Christian Kuhn uploaded patch set 3 V +1 04/14/23, 05:23

  7. Christian Kuhn commented on patch set 2 04/14/23, 05:23

    Deprecation-100581-AvoidConstructorArgumentInFormDataCompiler.rst:49 Reply

    Done
  8. core-ci voted on patch set 3 V -1 04/14/23, 05:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40585

  9. Christian Kuhn rebased onto patch set 4 V -1 04/14/23, 07:28

  10. core-ci voted on patch set 4 V +1 04/14/23, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40591

  11. Oli Bartsch voted on patch set 4 V +1 CR +1 04/14/23, 08:08

  12. Stefan Bürk voted on patch set 4 V +1 CR +1 04/14/23, 08:41

  13. Stefan Bürk voted on patch set 4 V +2 CR +2 04/14/23, 08:42

  14. Stefan Bürk merged patch set 5 04/14/23, 08:42