Review main Merged

78620[BUGFIX] Allow {__currentTimestamp} as form property

André Buchmann CR +2 V +2 Easy +2 −2 updated 04/14/23, 08:08

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. André Buchmann uploaded patch set 1 04/13/23, 14:28

  2. André Buchmann abandoned the change 04/13/23, 14:33

    Unwanted relation chain
  3. André Buchmann restored the change 04/13/23, 14:36

  4. André Buchmann rebased onto patch set 2 04/13/23, 14:36

  5. core-ci voted on patch set 2 V +1 04/13/23, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40572

  6. Oli Bartsch commented on patch set 2 V +1 CR +1 04/14/23, 07:19

    view-model.js:390

    We might want to make this more generic, e.g. by introducing some method "isFormElementSpecialIdentifierUsed()". However, I'm also fine with this solution for now, as this is the only special property.
  7. Jochen Roth voted on patch set 2 V +1 CR +1 04/14/23, 07:23

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 04/14/23, 08:08

  9. Christian Kuhn merged patch set 3 04/14/23, 08:08