Review main Merged

78625[TASK] Avoid last GU::linkThisScript() and deprecate

Christian Kuhn CR +2 V +2 Normal +115 −23 updated 04/14/23, 10:10

Commit message

GeneralUtility::linkThisScript() is one of the
last usages that access $_GET() from globals.

The patch removes a last usage and marks the
method @deprecated.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1520

  1. Christian Kuhn uploaded patch set 1 04/14/23, 06:40

  2. core-ci voted on patch set 1 V -1 04/14/23, 06:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40588

  3. Oliver Klee commented on patch set 1 04/14/23, 07:24

    ReturnUrl.php:41

    Let's make this a guard clause with an early return instead. Then we can get rid of one level of indentation.
  4. Christian Kuhn uploaded patch set 2 V -1 04/14/23, 07:31

  5. Christian Kuhn commented on patch set 1 04/14/23, 07:31

    ReturnUrl.php:41 Reply

    Done
  6. Oliver Klee voted on patch set 2 CR +1 04/14/23, 07:34

  7. core-ci voted on patch set 2 V -1 04/14/23, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40594

  8. Christian Kuhn uploaded patch set 3 CR +1 V -1 04/14/23, 09:29

  9. Christian Kuhn uploaded patch set 4 04/14/23, 09:37

  10. core-ci voted on patch set 3 V -1 04/14/23, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40597

  11. core-ci voted on patch set 4 V +1 04/14/23, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40598

  12. Benni Mack commented on patch set 4 V +1 CR +1 04/14/23, 09:47

    Thank you, the name and the contents of the RST is exactly how I think we should write deprecations. Amazing, thanks!
  13. Oliver Klee voted on patch set 4 V +1 CR +1 04/14/23, 09:51

  14. Oli Bartsch commented on patch set 4 CR -1 04/14/23, 09:54

    on it
  15. Oli Bartsch uploaded patch set 5 CR +1 V +1 04/14/23, 10:01

  16. Oli Bartsch commented on patch set 5 V +1 CR +1 04/14/23, 10:01

    Reply

    Done
  17. Oliver Klee voted on patch set 5 V +1 CR +1 04/14/23, 10:03

  18. core-ci voted on patch set 5 V +1 04/14/23, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40602

  19. Benni Mack voted on patch set 5 V +2 CR +2 04/14/23, 10:10

  20. Benni Mack merged patch set 6 04/14/23, 10:10