78625[TASK] Avoid last GU::linkThisScript() and deprecate
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Form/FormDataProvider/ReturnUrl.php2+37 −11
- typo3/sysext/backend/Configuration/Services.yaml+3 −0
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+0 −6
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+6 −6
- typo3/sysext/core/Documentation/Changelog/12.4/Deprecation-100584-GeneralUtilitylinkThisScript.rstnew+62 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
Review log 1520
-
Christian Kuhn uploaded patch set 1 04/14/23, 06:40
-
core-ci voted on patch set 1 V -1 04/14/23, 06:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40588
-
Oliver Klee commented on patch set 1 04/14/23, 07:24
-
Christian Kuhn uploaded patch set 2
V -104/14/23, 07:31 -
Christian Kuhn commented on patch set 1 04/14/23, 07:31
ReturnUrl.php:41ReplyDone -
Oliver Klee voted on patch set 2 CR +1 04/14/23, 07:34
-
core-ci voted on patch set 2 V -1 04/14/23, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40594
-
Christian Kuhn uploaded patch set 3
CR +1V -104/14/23, 09:29 -
Christian Kuhn uploaded patch set 4 04/14/23, 09:37
-
core-ci voted on patch set 3 V -1 04/14/23, 09:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40597
-
core-ci voted on patch set 4 V +1 04/14/23, 09:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40598
-
Benni Mack commented on patch set 4 V +1 CR +1 04/14/23, 09:47
Thank you, the name and the contents of the RST is exactly how I think we should write deprecations. Amazing, thanks! -
Oliver Klee voted on patch set 4 V +1 CR +1 04/14/23, 09:51
-
Oli Bartsch commented on patch set 4 CR -1 04/14/23, 09:54
on it -
Oli Bartsch uploaded patch set 5
CR +1V +104/14/23, 10:01 -
Oli Bartsch commented on patch set 5 V +1 CR +1 04/14/23, 10:01
Reply
Done -
Oliver Klee voted on patch set 5 V +1 CR +1 04/14/23, 10:03
-
core-ci voted on patch set 5 V +1 04/14/23, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40602
-
Benni Mack voted on patch set 5 V +2 CR +2 04/14/23, 10:10
-
Benni Mack merged patch set 6 04/14/23, 10:10
ReturnUrl.php:41