78631[TASK] Ensure working phpunit 10.1 for unit- and functional tests
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 3
Files 6
Review log 1521
-
Stefan Bürk uploaded patch set 1 04/14/23, 11:21
-
core-ci voted on patch set 1 V +1 04/14/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40606
-
Stefan Bürk uploaded patch set 2
V +104/14/23, 18:15 -
Stefan Bürk updated the commit message in patch set 3 04/14/23, 18:15
-
core-ci voted on patch set 3 V +1 04/14/23, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40640
-
Stefan Bürk commented on patch set 3 04/14/23, 18:27
Running nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/40641 -
Oliver Klee voted on patch set 3 V +1 CR +1 04/14/23, 18:28
-
core-ci voted on patch set 3 V -1 04/14/23, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40641
-
Oliver Klee commented on patch set 3 04/14/23, 19:30
The PHPStan build failure with the latest Composer packages is related to the Doctrine DBAL update and not related to PHPUnit. I'm currently creating a separate change for this. -
Stefan Bürk commented on patch set 3 04/14/23, 19:34
Reply
Thanks, sure .. got that. I will look for the config file stuff. -
Oliver Klee commented on patch set 3 04/14/23, 19:35
This is the fix for the PHPStan warning with the Doctrine DBAL update during the nightly build: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78644 -
Stefan Bürk commented on patch set 3 04/14/23, 19:46
Reply
Thanks. Seems the two functional was a hickup. We will rebase after the dbal patch has been merged and then rerun nightly. -
core-ci commented on patch set 3 04/14/23, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40641
-
Stefan Bürk commented on patch set 3 CR -1 04/14/23, 19:48
Reply
Nope, weired .. why it breaks inbetween. Will investigate this. -
Christian Kuhn commented on patch set 3 04/14/23, 22:23
-
Stefan Bürk uploaded patch set 4
CR +1V +104/14/23, 23:12 -
core-ci voted on patch set 4 V +1 04/14/23, 23:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40654
-
core-ci commented on patch set 4 04/14/23, 23:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40655
-
Christian Kuhn voted on patch set 4 V +1 CR +1 04/14/23, 23:49
-
Stefan Bürk commented on patch set 4 V +2 CR +2 04/14/23, 23:50
Slightly bending the rules. Only test related. -
Stefan Bürk merged patch set 5 04/14/23, 23:50