Review main Merged

78631[TASK] Ensure working phpunit 10.1 for unit- and functional tests

Stefan Bürk CR +2 V +2 Normal +50 −27 updated 04/14/23, 23:50

Commit message

PhpUnit 10.1 changed again some things from 10.0 -> 10.1,
like removing `RiskyTestError` exception and moving the
PhpUnit ErrorHandler to another namespace. Beside this,
phpunit 10.1 also needs a further config file migration
to additionl changed config file requirements.

This change updates typo3/testing-framework which contains
the fixes to be phpunit 10.1 compat, adjusts the config
files and ensures 10.1 for the unit10 and functional10 tests.

Additionally, the phpunit 10 unit and function config files
are adjusted to let notices and deprecations fail again and
therefore restore the wanted behaviour from phpunit 9 and
the removed `convert*ToException` options.

Used command(s):

> composer update typo3/testing-framework
> Build/Scripts/runTests.sh -s unit10 \
  -e '--migrate-configuration'
> Build/Scripts/runTests.sh -s unitDeprecated10 \
  -e '--migrate-configuration'
> Build/Scripts/runTests.sh -s functional10 \
  -e '--migrate-configuration'
> Build/Scripts/runTests.sh -s functionalDeprecated10 \
  -e '--migrate-configuration'

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 1521

  1. Stefan Bürk uploaded patch set 1 04/14/23, 11:21

  2. core-ci voted on patch set 1 V +1 04/14/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40606

  3. Stefan Bürk uploaded patch set 2 V +1 04/14/23, 18:15

  4. Stefan Bürk updated the commit message in patch set 3 04/14/23, 18:15

  5. core-ci voted on patch set 3 V +1 04/14/23, 18:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40640

  6. Stefan Bürk commented on patch set 3 04/14/23, 18:27

  7. Oliver Klee voted on patch set 3 V +1 CR +1 04/14/23, 18:28

  8. core-ci voted on patch set 3 V -1 04/14/23, 19:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40641

  9. Oliver Klee commented on patch set 3 04/14/23, 19:30

    The PHPStan build failure with the latest Composer packages is related to the Doctrine DBAL update and not related to PHPUnit. I'm currently creating a separate change for this.
  10. Stefan Bürk commented on patch set 3 04/14/23, 19:34

    Reply

    Thanks, sure .. got that. I will look for the config file stuff.
  11. Oliver Klee commented on patch set 3 04/14/23, 19:35

    This is the fix for the PHPStan warning with the Doctrine DBAL update during the nightly build: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78644
  12. Stefan Bürk commented on patch set 3 04/14/23, 19:46

    Reply

    Thanks. Seems the two functional was a hickup. We will rebase after the dbal patch has been merged and then rerun nightly.
  13. core-ci commented on patch set 3 04/14/23, 19:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40641

  14. Stefan Bürk commented on patch set 3 CR -1 04/14/23, 19:48

    Reply

    Nope, weired .. why it breaks inbetween. Will investigate this.
  15. Christian Kuhn commented on patch set 3 04/14/23, 22:23

  16. Stefan Bürk uploaded patch set 4 CR +1 V +1 04/14/23, 23:12

  17. core-ci voted on patch set 4 V +1 04/14/23, 23:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40654

  18. core-ci commented on patch set 4 04/14/23, 23:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40655

  19. Christian Kuhn voted on patch set 4 V +1 CR +1 04/14/23, 23:49

  20. Stefan Bürk commented on patch set 4 V +2 CR +2 04/14/23, 23:50

    Slightly bending the rules. Only test related.
  21. Stefan Bürk merged patch set 5 04/14/23, 23:50