Review main Merged

78636[TASK] Deprecate form engine result property additionalJavaScriptPost

Oliver Hader CR +2 V +2 Normal +104 −9 updated 04/14/23, 14:16

Commit message

Deprecates form engine result property `additionalJavaScriptPost`,
which was used by custom evaluation that provided inline JavaScript
(`$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tce']['formevals']`).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Oliver Hader uploaded patch set 1 04/14/23, 12:33

  2. core-ci voted on patch set 1 V +1 04/14/23, 12:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40616

  3. Oliver Hader uploaded patch set 2 V +1 04/14/23, 13:23

  4. Oliver Hader marked it ready for review 04/14/23, 13:24

  5. core-ci voted on patch set 2 V +1 04/14/23, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40621

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 04/14/23, 14:00

  7. Benni Mack voted on patch set 2 V +2 CR +2 04/14/23, 14:16

  8. Benni Mack merged patch set 3 04/14/23, 14:16