Review main Merged

78637[TASK] Do not set   as label for checkboxes in debug mode

Benjamin Kott CR +2 V +2 Easy +7 −10 updated 04/14/23, 14:19

Commit message

There is no need to add a non-breaking space as a fallback if the label
is empty for checkboxes. This results in unnecessary occupied
space. We prefer just an empty string.

To ensure we only occupy the space we need to, we are trimming
unnecessary whitespaces from the final label.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Benjamin Kott uploaded patch set 1 04/14/23, 12:38

  2. core-ci voted on patch set 1 V +1 04/14/23, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40617

  3. Oliver Klee voted on patch set 1 CR +1 04/14/23, 13:11

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 04/14/23, 14:01

  5. Benni Mack voted on patch set 1 V +2 CR +2 04/14/23, 14:19

  6. Benni Mack merged patch set 2 04/14/23, 14:19