Review main Merged

78639[TASK] Deprecate GeneralUtility::_GET()

Christian Kuhn CR +2 V +2 Normal +98 −42 updated 04/14/23, 14:30

Commit message

This deprecates GeneralUtility::_GET() as last
member of the get/post related family, next to
GU::_POST(), GU::_GP() and GU::_GPmerged(): The
request object has to be used instead.

This patch is the end of a journey that took
us various years. The last main one left is
GeneralUtility::getIndpEnv(), but that's a
story for TYPO3 v13.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 9

Review log 1316

  1. Christian Kuhn uploaded patch set 1 04/14/23, 13:36

  2. core-ci voted on patch set 1 V +1 04/14/23, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40623

  3. Benni Mack commented on patch set 1 CR -1 04/14/23, 13:53

    Deprecation-100596-GeneralUtility_GET.rst:65

    nope. this is GP not GET
  4. Benni Mack commented on patch set 1 04/14/23, 13:54

    Deprecation-100596-GeneralUtility_GET.rst:14

    Wrong namespace
  5. Christian Kuhn commented on patch set 1 04/14/23, 13:56

    Deprecation-100596-GeneralUtility_GET.rst:14 Reply

    good catch. copied from other .rst files. will adapt.

    Deprecation-100596-GeneralUtility_GET.rst:65 Reply

    Done
  6. Christian Kuhn uploaded patch set 2 CR -1 V +1 04/14/23, 13:57

  7. core-ci voted on patch set 2 V +1 04/14/23, 14:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40625

  8. Oliver Klee voted on patch set 2 V +1 CR +1 04/14/23, 14:07

  9. Benni Mack commented on patch set 2 CR -1 04/14/23, 14:20

    Deprecation-100596-GeneralUtility_GET.rst:59

    sorry, wrong use statement
  10. Christian Kuhn uploaded patch set 3 CR +1 V +1 04/14/23, 14:22

  11. Benni Mack commented on patch set 3 V +1 CR +1 04/14/23, 14:22

    Deprecation-100596-GeneralUtility_GET.rst:59 Reply

    Done
  12. Christian Kuhn commented on patch set 3 04/14/23, 14:22

    Deprecation-100596-GeneralUtility_GET.rst:59 Reply

    foo
  13. Oliver Klee voted on patch set 3 V +1 CR +1 04/14/23, 14:28

  14. core-ci voted on patch set 3 V +1 04/14/23, 14:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40627

  15. Christian Kuhn voted on patch set 3 V +2 CR +2 04/14/23, 14:30

  16. Christian Kuhn merged patch set 4 04/14/23, 14:30