Review main Merged

78640[TASK] Simplify code in LazyObjectStorage

Oliver Klee CR +2 V +2 Easy +12 −10 updated 04/14/23, 17:52

Commit message

Simplify `initialize` using a guard clause.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oliver Klee uploaded patch set 1 04/14/23, 14:47

  2. Oliver Klee wrote 04/14/23, 14:47

    Topic set to extbase
  3. core-ci voted on patch set 1 V +1 04/14/23, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40630

  4. Oli Bartsch commented on patch set 1 04/14/23, 14:58

    Should this be backported to 11.5?
  5. Oliver Klee commented on patch set 1 04/14/23, 15:04

    Reply

    I don't find it important to backport this, but wouldn't be opposed to doing so if it made someone happy. :-) (In other words: If you'd like this change to get backported, please feel free to do so.)
  6. Oli Bartsch updated the commit message in patch set 2 V +1 04/14/23, 15:06

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 04/14/23, 15:06

  8. core-ci voted on patch set 2 V +1 04/14/23, 15:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40631

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 04/14/23, 17:52

  10. Stefan Bürk merged patch set 3 04/14/23, 17:52