Review main Merged

78642[BUGFIX] Adjust return value in DeprecatingRequestWrapper

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 04/14/23, 19:49

Commit message

With #100567, the return type of the getPageArguments()
method in RequestWrapper and DeprecatingRequestWrapper
was changed to PageArguments, while the actual return value
was only adjusted in the RequestWrapper.

This is now also done in DeprecatingRequestWrapper.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 04/14/23, 16:50

  2. Benni Mack voted on patch set 1 V +1 CR +1 04/14/23, 16:51

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 04/14/23, 17:47

  4. core-ci voted on patch set 1 V +1 04/14/23, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40634

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 04/14/23, 19:49

  6. Christian Kuhn merged patch set 2 04/14/23, 19:49