Review main Merged

78643[TASK] Align scheduler add/edit form of a task with FormEngine markup

Jasmina Ließmann CR +2 V +2 Hard +401 −208 updated 04/24/23, 17:13

Commit message

With #100042 the markup of the form fields in the add/edit form of a
task has been updated. With this patch the markup was updated again
to fully match the FormEngine's form field markup.
With this we create the prerequisite that rollouts of global style
adjustments for form fields also work on this form.

Mid-term, this module should use FormEngine for rendering anyway,
so this is kind of another pre-patch.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 32

Show 12 more files

Review log 1729

Show 24 earlier messages
  1. Jasmina Ließmann uploaded patch set 1 04/14/23, 19:16

  2. core-ci voted on patch set 1 V -1 04/14/23, 19:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40642

  3. Jasmina Ließmann uploaded patch set 2 V -1 04/15/23, 19:31

  4. core-ci voted on patch set 2 V +1 04/15/23, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40701

  1. Jasmina Ließmann updated the commit message in patch set 3 V +1 04/15/23, 19:49

  2. Jasmina Ließmann updated the commit message in patch set 4 04/15/23, 19:50

  3. core-ci voted on patch set 4 V +1 04/15/23, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40703

  4. core-ci voted on patch set 3 V +1 04/15/23, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40702

  5. Jasmina Ließmann updated the commit message in patch set 5 V +1 04/15/23, 20:05

  6. core-ci voted on patch set 5 V +1 04/15/23, 20:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40706

  7. Jasmina Ließmann commented on patch set 5 CR -1 04/16/23, 13:00

    Will do some changes here again.
  8. Jasmina Ließmann uploaded patch set 6 CR -1 V +1 04/16/23, 15:03

  9. core-ci voted on patch set 6 V -1 04/16/23, 15:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40747

  10. Jasmina Ließmann uploaded patch set 7 V -1 04/16/23, 15:13

  11. Jasmina Ließmann uploaded patch set 8 04/16/23, 15:18

  12. core-ci voted on patch set 7 V -1 04/16/23, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40749

  13. core-ci voted on patch set 8 V +1 04/16/23, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40751

  14. Jasmina Ließmann uploaded patch set 9 V +1 04/16/23, 16:37

  15. Jasmina Ließmann commented on patch set 9 04/16/23, 16:38

    Reply

    Done
  16. core-ci voted on patch set 9 V -1 04/16/23, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40754

  17. Jasmina Ließmann uploaded patch set 10 V -1 04/16/23, 17:13

  18. core-ci voted on patch set 10 V +1 04/16/23, 17:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40758

  19. Jasmina Ließmann uploaded patch set 11 V +1 04/24/23, 13:12

  20. Jasmina Ließmann updated the commit message in patch set 12 04/24/23, 13:14

  21. core-ci voted on patch set 12 V +1 04/24/23, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41165

  22. core-ci voted on patch set 11 V +1 04/24/23, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41164

  23. Christian Kuhn voted on patch set 12 V +1 CR +1 04/24/23, 16:53

  24. Stefan Bürk voted on patch set 12 V +2 CR +2 04/24/23, 17:13

  25. Stefan Bürk merged patch set 13 04/24/23, 17:13