Review main Merged

78644[TASK] Update Doctrine DBAL

Oliver Klee CR +2 V +2 Easy +13 −23 updated 04/14/23, 19:59

Commit message

This update fixes some PHPStan warnings for us.

> composer req doctrine/dbal:^3.6.2
> composer req doctrine/dbal:^3.6.2 --no-update -d typo3/sysext/core
> composer req doctrine/dbal:^3.6.2 --no-update -d typo3/sysext/install
> composer req doctrine/dbal:^3.6.2 --no-update -d \
  typo3/sysext/redirects
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 69

  1. Oliver Klee uploaded patch set 1 04/14/23, 19:34

  2. Oliver Klee updated the commit message in patch set 2 04/14/23, 19:38

  3. core-ci voted on patch set 1 V +1 04/14/23, 19:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40643

  4. core-ci voted on patch set 2 V +1 04/14/23, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40644

  5. Stefan Bürk updated the commit message in patch set 3 V +1 04/14/23, 19:50

  6. core-ci voted on patch set 3 V +1 04/14/23, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40645

  7. Stefan Bürk voted on patch set 3 V +1 CR +1 04/14/23, 19:58

  8. Christian Kuhn voted on patch set 3 V +2 CR +2 04/14/23, 19:59

  9. Christian Kuhn merged patch set 4 04/14/23, 19:59